| Message ID | 20191015135148.28508-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0ff35966d171ec99b118df666c1687cc86ba8d7e |
| Headers | show |
| Series | phy: stm32: fix use of integer as pointer | expand |
On 10/15/19 3:51 PM, Ben Dooks wrote: > The calls devm_clk_get() and devm_reset_control_get() > take pointers so change the 0 to NULl to fix the > following sparse warnings: > > drivers/phy/st/phy-stm32-usbphyc.c:330:42: warning: Using plain integer as NULL pointer > drivers/phy/st/phy-stm32-usbphyc.c:343:52: warning: Using plain integer as NULL pointer > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Reviewed-by: Amelie Delaunay <amelie.delaunay@st.com> > --- > Cc: Kishon Vijay Abraham I <kishon@ti.com> > Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> > Cc: Alexandre Torgue <alexandre.torgue@st.com> > Cc: linux-kernel@vger.kernel.org > Cc: linux-stm32@st-md-mailman.stormreply.com > Cc: linux-arm-kernel@lists.infradead.org > --- > drivers/phy/st/phy-stm32-usbphyc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c > index 56bdea4b0bd9..2b3639cba51a 100644 > --- a/drivers/phy/st/phy-stm32-usbphyc.c > +++ b/drivers/phy/st/phy-stm32-usbphyc.c > @@ -327,7 +327,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev) > if (IS_ERR(usbphyc->base)) > return PTR_ERR(usbphyc->base); > > - usbphyc->clk = devm_clk_get(dev, 0); > + usbphyc->clk = devm_clk_get(dev, NULL); > if (IS_ERR(usbphyc->clk)) { > ret = PTR_ERR(usbphyc->clk); > dev_err(dev, "clk get failed: %d\n", ret); > @@ -340,7 +340,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev) > return ret; > } > > - usbphyc->rst = devm_reset_control_get(dev, 0); > + usbphyc->rst = devm_reset_control_get(dev, NULL); > if (!IS_ERR(usbphyc->rst)) { > reset_control_assert(usbphyc->rst); > udelay(2); >
diff --git a/drivers/phy/st/phy-stm32-usbphyc.c b/drivers/phy/st/phy-stm32-usbphyc.c index 56bdea4b0bd9..2b3639cba51a 100644 --- a/drivers/phy/st/phy-stm32-usbphyc.c +++ b/drivers/phy/st/phy-stm32-usbphyc.c @@ -327,7 +327,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev) if (IS_ERR(usbphyc->base)) return PTR_ERR(usbphyc->base); - usbphyc->clk = devm_clk_get(dev, 0); + usbphyc->clk = devm_clk_get(dev, NULL); if (IS_ERR(usbphyc->clk)) { ret = PTR_ERR(usbphyc->clk); dev_err(dev, "clk get failed: %d\n", ret); @@ -340,7 +340,7 @@ static int stm32_usbphyc_probe(struct platform_device *pdev) return ret; } - usbphyc->rst = devm_reset_control_get(dev, 0); + usbphyc->rst = devm_reset_control_get(dev, NULL); if (!IS_ERR(usbphyc->rst)) { reset_control_assert(usbphyc->rst); udelay(2);
The calls devm_clk_get() and devm_reset_control_get() take pointers so change the 0 to NULl to fix the following sparse warnings: drivers/phy/st/phy-stm32-usbphyc.c:330:42: warning: Using plain integer as NULL pointer drivers/phy/st/phy-stm32-usbphyc.c:343:52: warning: Using plain integer as NULL pointer Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Kishon Vijay Abraham I <kishon@ti.com> Cc: Maxime Coquelin <mcoquelin.stm32@gmail.com> Cc: Alexandre Torgue <alexandre.torgue@st.com> Cc: linux-kernel@vger.kernel.org Cc: linux-stm32@st-md-mailman.stormreply.com Cc: linux-arm-kernel@lists.infradead.org --- drivers/phy/st/phy-stm32-usbphyc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)