| Message ID | 20191017103934.6814-1-ben.dooks@codethink.co.uk (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | zx: make zx_smp_prepare_cpus static | expand |
On Thu, Oct 17, 2019 at 11:39:34AM +0100, Ben Dooks (Codethink) wrote: > The zx_smp_prepare_cpus is not declared and not directly > exported outside of the file it is in. Make it static to > remove the following sparse warning: > > arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared. Should it be static? > > Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> Acked-by: Shawn Guo <shawnguo@kernel.org> @Arnd, please help apply it to arm-soc, thanks! Shawn > --- > Cc: Jun Nie <jun.nie@linaro.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Russell King <linux@armlinux.org.uk> > Cc: linux-arm-kernel@lists.infradead.org > --- > arch/arm/mach-zx/platsmp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c > index d4e1d3792224..43a33eaff388 100644 > --- a/arch/arm/mach-zx/platsmp.c > +++ b/arch/arm/mach-zx/platsmp.c > @@ -38,7 +38,7 @@ static void __iomem *pcu_base; > static void __iomem *matrix_base; > static void __iomem *scu_base; > > -void __init zx_smp_prepare_cpus(unsigned int max_cpus) > +static void __init zx_smp_prepare_cpus(unsigned int max_cpus) > { > struct device_node *np; > unsigned long base = 0; > -- > 2.23.0 >
diff --git a/arch/arm/mach-zx/platsmp.c b/arch/arm/mach-zx/platsmp.c index d4e1d3792224..43a33eaff388 100644 --- a/arch/arm/mach-zx/platsmp.c +++ b/arch/arm/mach-zx/platsmp.c @@ -38,7 +38,7 @@ static void __iomem *pcu_base; static void __iomem *matrix_base; static void __iomem *scu_base; -void __init zx_smp_prepare_cpus(unsigned int max_cpus) +static void __init zx_smp_prepare_cpus(unsigned int max_cpus) { struct device_node *np; unsigned long base = 0;
The zx_smp_prepare_cpus is not declared and not directly exported outside of the file it is in. Make it static to remove the following sparse warning: arch/arm/mach-zx/platsmp.c:41:13: warning: symbol 'zx_smp_prepare_cpus' was not declared. Should it be static? Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk> --- Cc: Jun Nie <jun.nie@linaro.org> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Russell King <linux@armlinux.org.uk> Cc: linux-arm-kernel@lists.infradead.org --- arch/arm/mach-zx/platsmp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)