| Message ID | 20191021091509.3864-9-narmstrong@baylibre.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 24e0d4058eff7cdf66976c66be42ac89f94d1d16 |
| Headers | show |
| Series | drm/meson: add AFBC support | expand |
Neil Armstrong <narmstrong@baylibre.com> writes: > When using an AFBC encoded frame, the AFBC Decoder must be resetted, minor grammar nit: s/resetted/reset/ > configured and enabled at each vsync IRQ. > > To leave time for that, use the maximum lines hold time to give time > for AFBC setup and avoid visual glitches. > > Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> otherwise... Reviewed-by: Kevin Hilman <khilman@baylibre.com>
diff --git a/drivers/gpu/drm/meson/meson_viu.c b/drivers/gpu/drm/meson/meson_viu.c index fc246248226b..304f8ff1339c 100644 --- a/drivers/gpu/drm/meson/meson_viu.c +++ b/drivers/gpu/drm/meson/meson_viu.c @@ -438,7 +438,7 @@ void meson_viu_init(struct meson_drm *priv) /* Initialize OSD1 fifo control register */ reg = VIU_OSD_DDR_PRIORITY_URGENT | - VIU_OSD_HOLD_FIFO_LINES(4) | + VIU_OSD_HOLD_FIFO_LINES(31) | VIU_OSD_FIFO_DEPTH_VAL(32) | /* fifo_depth_val: 32*8=256 */ VIU_OSD_WORDS_PER_BURST(4) | /* 4 words in 1 burst */ VIU_OSD_FIFO_LIMITS(2); /* fifo_lim: 2*16=32 */
When using an AFBC encoded frame, the AFBC Decoder must be resetted, configured and enabled at each vsync IRQ. To leave time for that, use the maximum lines hold time to give time for AFBC setup and avoid visual glitches. Signed-off-by: Neil Armstrong <narmstrong@baylibre.com> --- drivers/gpu/drm/meson/meson_viu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)