| Message ID | 20191028215859.3467317-1-megous@megous.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | e614f341253f8541baf0230a8dc6a016b544b1e2 |
| Headers | show |
| Series | ARM: dts: sun8i-a83t-tbs-a711: Fix WiFi resume from suspend | expand |
On Mon, Oct 28, 2019 at 10:58:58PM +0100, Ondrej Jirman wrote: > Without enabling keep-power-in-suspend, we can't wake the device > up using WOL packet, and the log is flooded with these messages > on resume: > > sunxi-mmc 1c10000.mmc: send stop command failed > sunxi-mmc 1c10000.mmc: data error, sending stop command > sunxi-mmc 1c10000.mmc: send stop command failed > sunxi-mmc 1c10000.mmc: data error, sending stop command > > So to make the WiFi really a wakeup-source, we need to keep it powered > during suspend. > > Fixes: 0e23372080def7 ("arm: dts: sun8i: Add the TBS A711 tablet devicetree") > Signed-off-by: Ondrej Jirman <megous@megous.com> Applied, thanks! (I don't have my ssh key with me, so it might take a while before it's pushed...) Maxime
diff --git a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts index 43b21599898e..5b8c9c24350b 100644 --- a/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts +++ b/arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts @@ -311,6 +311,7 @@ vqmmc-supply = <®_dldo1>; non-removable; wakeup-source; + keep-power-in-suspend; status = "okay"; brcmf: wifi@1 {
Without enabling keep-power-in-suspend, we can't wake the device up using WOL packet, and the log is flooded with these messages on resume: sunxi-mmc 1c10000.mmc: send stop command failed sunxi-mmc 1c10000.mmc: data error, sending stop command sunxi-mmc 1c10000.mmc: send stop command failed sunxi-mmc 1c10000.mmc: data error, sending stop command So to make the WiFi really a wakeup-source, we need to keep it powered during suspend. Fixes: 0e23372080def7 ("arm: dts: sun8i: Add the TBS A711 tablet devicetree") Signed-off-by: Ondrej Jirman <megous@megous.com> --- arch/arm/boot/dts/sun8i-a83t-tbs-a711.dts | 1 + 1 file changed, 1 insertion(+)