| Message ID | 20191101121725.13349-1-hslester96@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 4202e219edd6cc164c042e16fa327525410705ae |
| Headers | show |
| Series | net: ethernet: arc: add the missed clk_disable_unprepare | expand |
From: Chuhong Yuan <hslester96@gmail.com> Date: Fri, 1 Nov 2019 20:17:25 +0800 > The remove misses to disable and unprepare priv->macclk like what is done > when probe fails. > Add the missed call in remove. > > Signed-off-by: Chuhong Yuan <hslester96@gmail.com> Applied, thank you.
diff --git a/drivers/net/ethernet/arc/emac_rockchip.c b/drivers/net/ethernet/arc/emac_rockchip.c index 42d2e1b02c44..664d664e0925 100644 --- a/drivers/net/ethernet/arc/emac_rockchip.c +++ b/drivers/net/ethernet/arc/emac_rockchip.c @@ -256,6 +256,9 @@ static int emac_rockchip_remove(struct platform_device *pdev) if (priv->regulator) regulator_disable(priv->regulator); + if (priv->soc_data->need_div_macclk) + clk_disable_unprepare(priv->macclk); + free_netdev(ndev); return err; }
The remove misses to disable and unprepare priv->macclk like what is done when probe fails. Add the missed call in remove. Signed-off-by: Chuhong Yuan <hslester96@gmail.com> --- drivers/net/ethernet/arc/emac_rockchip.c | 3 +++ 1 file changed, 3 insertions(+)