| Message ID | 20191106120021.115200-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 9def5dc10d3e21cf7673731be21224b6cc0eb16a |
| Headers | show |
| Series | [-next] coresight: funnel: Fix missing spin_lock_init() | expand |
Thanks for the fix! I should have tested with CONFIG_DEBUG_SPINLOCK.
Tested-by: Yabin Cui <yabinc@google.com>
diff --git a/drivers/hwtracing/coresight/coresight-funnel.c b/drivers/hwtracing/coresight/coresight-funnel.c index b605889b507a..900690a9f7f0 100644 --- a/drivers/hwtracing/coresight/coresight-funnel.c +++ b/drivers/hwtracing/coresight/coresight-funnel.c @@ -253,6 +253,7 @@ static int funnel_probe(struct device *dev, struct resource *res) } dev->platform_data = pdata; + spin_lock_init(&drvdata->spinlock); desc.type = CORESIGHT_DEV_TYPE_LINK; desc.subtype.link_subtype = CORESIGHT_DEV_SUBTYPE_LINK_MERG; desc.ops = &funnel_cs_ops;
The driver allocates the spinlock but not initialize it. Use spin_lock_init() on it to initialize it correctly. This is detected by Coccinelle semantic patch. Fixes: 0093875ad129 ("coresight: Serialize enabling/disabling a link device.") Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/hwtracing/coresight/coresight-funnel.c | 1 + 1 file changed, 1 insertion(+)