| Message ID | 20191106153213.13752-1-weiyongjun1@huawei.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 0d962c3ae13ab2f4cb1c009295da4e70abc4e3c2 |
| Headers | show |
| Series | [-next] media: sun8i: Remove redundant dev_err call in deinterlace_probe() | expand |
Hi! Dne sreda, 06. november 2019 ob 16:32:12 CET je Wei Yongjun napisal(a): > There is a error message within devm_ioremap_resource > already, so remove the dev_err call to avoid redundant > error message. > > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> Acked-by: Jernej Skrabec <jernej.skrabec@siol.net> Best regards, Jernej > --- > drivers/media/platform/sunxi/sun8i-di/sun8i-di.c | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c > b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c index > aaa1dc159ac2..b61f3dea7c93 100644 > --- a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c > +++ b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c > @@ -834,11 +834,8 @@ static int deinterlace_probe(struct platform_device > *pdev) > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > dev->base = devm_ioremap_resource(&pdev->dev, res); > - if (IS_ERR(dev->base)) { > - dev_err(dev->dev, "Failed to map registers\n"); > - > + if (IS_ERR(dev->base)) > return PTR_ERR(dev->base); > - } > > dev->bus_clk = devm_clk_get(dev->dev, "bus"); > if (IS_ERR(dev->bus_clk)) {
diff --git a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c index aaa1dc159ac2..b61f3dea7c93 100644 --- a/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c +++ b/drivers/media/platform/sunxi/sun8i-di/sun8i-di.c @@ -834,11 +834,8 @@ static int deinterlace_probe(struct platform_device *pdev) res = platform_get_resource(pdev, IORESOURCE_MEM, 0); dev->base = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(dev->base)) { - dev_err(dev->dev, "Failed to map registers\n"); - + if (IS_ERR(dev->base)) return PTR_ERR(dev->base); - } dev->bus_clk = devm_clk_get(dev->dev, "bus"); if (IS_ERR(dev->bus_clk)) {
There is a error message within devm_ioremap_resource already, so remove the dev_err call to avoid redundant error message. Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com> --- drivers/media/platform/sunxi/sun8i-di/sun8i-di.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-)