| Message ID | 20191111114655.9583-1-m.grzeschik@pengutronix.de (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | e50811396a4941c629797dd51c9c0a1606414cbd |
| Headers | show |
| Series | ARM: dts: imx25: fix usbhost1 node | expand |
On Mon, Nov 11, 2019 at 12:46:56PM +0100, Michael Grzeschik wrote: > The usb port represented by &usbhost1 uses an USB phy internal to the > SoC. We add the phy_type to the base dtsi so the board dts only have to > overwrite it if they use a different configuration. While at it we also > pin the usbhost port to host mode. > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks Uwe
On Thu, Nov 14, 2019 at 10:17:08PM +0100, Uwe Kleine-König wrote: > On Mon, Nov 11, 2019 at 12:46:56PM +0100, Michael Grzeschik wrote: > > The usb port represented by &usbhost1 uses an USB phy internal to the > > SoC. We add the phy_type to the base dtsi so the board dts only have to > > overwrite it if they use a different configuration. While at it we also > > pin the usbhost port to host mode. > > > > Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> > Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Thanks for the ACK. I just figured out that we also can add the limitation to maximum-speed = "full-speed" into to dts. Since the internal phy maximum speed is limited to that. I will send an v2.
diff --git a/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts b/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts index 0fde90df2b546..3f38c2e60a745 100644 --- a/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts +++ b/arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts @@ -165,8 +165,6 @@ }; &usbhost1 { - phy_type = "serial"; - dr_mode = "host"; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx25-pdk.dts b/arch/arm/boot/dts/imx25-pdk.dts index 05cccd12624cb..fb66884d8a2fa 100644 --- a/arch/arm/boot/dts/imx25-pdk.dts +++ b/arch/arm/boot/dts/imx25-pdk.dts @@ -304,8 +304,6 @@ }; &usbhost1 { - phy_type = "serial"; - dr_mode = "host"; status = "okay"; }; diff --git a/arch/arm/boot/dts/imx25.dtsi b/arch/arm/boot/dts/imx25.dtsi index 9a097ef014af5..7c7795b40ee0c 100644 --- a/arch/arm/boot/dts/imx25.dtsi +++ b/arch/arm/boot/dts/imx25.dtsi @@ -570,6 +570,8 @@ clock-names = "ipg", "ahb", "per"; fsl,usbmisc = <&usbmisc 1>; fsl,usbphy = <&usbphy1>; + phy_type = "serial"; + dr_mode = "host"; status = "disabled"; };
The usb port represented by &usbhost1 uses an USB phy internal to the SoC. We add the phy_type to the base dtsi so the board dts only have to overwrite it if they use a different configuration. While at it we also pin the usbhost port to host mode. Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de> --- arch/arm/boot/dts/imx25-eukrea-mbimxsd25-baseboard.dts | 2 -- arch/arm/boot/dts/imx25-pdk.dts | 2 -- arch/arm/boot/dts/imx25.dtsi | 2 ++ 3 files changed, 2 insertions(+), 4 deletions(-)