From patchwork Mon Nov 18 11:41:15 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chuhong Yuan X-Patchwork-Id: 11249671 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7B46B1390 for ; Mon, 18 Nov 2019 11:41:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 166EE20727 for ; Mon, 18 Nov 2019 11:41:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Pw0CFllR"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gm6zRK0P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 166EE20727 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=PKodFV0P/Ir71x3biL5j8A/6MvHEM6ykJsLvxc8J9O0=; b=Pw0CFllRRkvg4g ySTtp7cuu82aZpMZfzwHdGLf598dROvyKJQm9uy2VFWVz+iuGwsbt03E7b5ZjutWVoCuo+rmqoTL3 E9pd+sMo3zJw4lz0cfM12+5nXU9Ze+Yx5cFmGR+t+wDGqmCFG/QfvUVE3rO6TsKnNG+FTW2WWi4JE xi2wqphDwUmWR4WQOAHStuhgr7hAWcNkFvjk2MLk5TjTMzb9bT8XyWa3F+FVoyDX0cAlyHPDXMj/C gtkh3lTgPU55vIRlwFEuEx8sLvLnBRoV/GdIeQQs+wHOdTdtQbGt3KlrhVkFgr+NwKzy8jRojlFlX Eyx1rK6+lTwda6gjEJpg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWfPN-0003N8-Jc; Mon, 18 Nov 2019 11:41:29 +0000 Received: from mail-pl1-x643.google.com ([2607:f8b0:4864:20::643]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iWfPL-0003Ml-Ck for linux-arm-kernel@lists.infradead.org; Mon, 18 Nov 2019 11:41:28 +0000 Received: by mail-pl1-x643.google.com with SMTP id o9so9658700plk.6 for ; Mon, 18 Nov 2019 03:41:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y3dNvZGOTXHcwszhaSWaecoVEi7Q+cvDM3heVVZqOJg=; b=Gm6zRK0PEAuSnXmueVoIk7R0Vg6pkNCYcWQpO5nxbzU/hruF6Ou2tHv5IocAFc1HlB Vugo8BvFrz8kBMfgtONaJlHsIAeN+DAYWoArivrHDbrXDa0Ly+eGhmHfGtB2df7m1JJY Gwk7uppd0rRlPfJCYGzbLrE8D/Vu/lfnxmeJKnXJX/IlkuY0nOSqNbEYXN8gho2zJtkp MK60tua+o/kgRutSu5lgTnXfNIX9zmBNHI8xY9WThF48wr0OpjE/9zkKwSNfQMqb87xF iRXdv2MunyU3ssfscV7E84s9yJ8tIqt/lmXjvfhjlEvhIsUU/0c3qJflgrOZFovy21vS S4Cg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=y3dNvZGOTXHcwszhaSWaecoVEi7Q+cvDM3heVVZqOJg=; b=cdP+sUdS5fe3F2N5aDKFfpc8PzzKP+ImRoGx9U4Apz/Zvzw0SRUEKb7d30Haq6Fip6 BJFvVdbrs4mkQ8UtuFh9i1xve8TIpKFsrkgre7Rz/g6t2q4zxSWDweYLCNCTrAPfMOw4 e2gcbfsI0jQCUrPNGCic0pXxuQWllyG2k/XrXxXUDnLPwfB4qSt6y2slTzymPa8MZJaF /gsTBofCuSYWKzekXRdHPT593ahuXGG8IFHmokA8XreFsBsSEcTOYd2WCKHUpkESL1LO ztV+l/Hkc0sJLTj3J7PwwqhXNcoKz03E/MjWm8FO0G8dD68VBlV0i6TdXRMEntTiToCj l41A== X-Gm-Message-State: APjAAAV26DOp32YZxJ03PUolY2Dxfol+84WYXtIJNrCPbVo3MMW6zC73 s//dU7lOHu8pjx/ECFLly3o= X-Google-Smtp-Source: APXvYqxkb+Di6ZGVFvNAuyKzeK5xAMC329UbduP0YsF1FEoBa/nqARtsD7TnIOAOrl6I/wMrI+DF3g== X-Received: by 2002:a17:90a:bd95:: with SMTP id z21mr39237600pjr.10.1574077287005; Mon, 18 Nov 2019 03:41:27 -0800 (PST) Received: from suzukaze.ipads-lab.se.sjtu.edu.cn ([202.120.40.82]) by smtp.gmail.com with ESMTPSA id x192sm23480122pfd.96.2019.11.18.03.41.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2019 03:41:26 -0800 (PST) From: Chuhong Yuan To: Subject: [PATCH] phy: mdio-sun4i: add missed regulator_disable in remove Date: Mon, 18 Nov 2019 19:41:15 +0800 Message-Id: <20191118114115.25608-1-hslester96@gmail.com> X-Mailer: git-send-email 2.24.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191118_034127_432147_8A6E0250 X-CRM114-Status: GOOD ( 10.73 ) X-Spam-Score: 1.6 (+) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (1.6 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:643 listed in] [list.dnswl.org] 1.5 RCVD_IN_SORBS_WEB RBL: SORBS: sender is an abusable web server [202.120.40.82 listed in dnsbl.sorbs.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (hslester96[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (hslester96[at]gmail.com) 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrew Lunn , Florian Fainelli , netdev@vger.kernel.org, Chuhong Yuan , linux-kernel@vger.kernel.org, Maxime Ripard , Chen-Yu Tsai , "David S . Miller" , linux-arm-kernel@lists.infradead.org, Heiner Kallweit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The driver forgets to disable the regulator in remove like what is done in probe failure. Add the missed call to fix it. Signed-off-by: Chuhong Yuan --- drivers/net/phy/mdio-sun4i.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/mdio-sun4i.c b/drivers/net/phy/mdio-sun4i.c index 58d6504495e0..f798de3276dc 100644 --- a/drivers/net/phy/mdio-sun4i.c +++ b/drivers/net/phy/mdio-sun4i.c @@ -145,8 +145,11 @@ static int sun4i_mdio_probe(struct platform_device *pdev) static int sun4i_mdio_remove(struct platform_device *pdev) { struct mii_bus *bus = platform_get_drvdata(pdev); + struct sun4i_mdio_data *data = bus->priv; mdiobus_unregister(bus); + if (data->regulator) + regulator_disable(data->regulator); mdiobus_free(bus); return 0;