diff mbox series

arm64: dts: ti: k3-j721e-main: Add missing power-domains for smmu

Message ID 20191122100356.20622-1-lokeshvutla@ti.com (mailing list archive)
State Mainlined
Commit 3f03a58b25753843ce9e4511e9e246c51bd11011
Headers show
Series arm64: dts: ti: k3-j721e-main: Add missing power-domains for smmu | expand

Commit Message

Lokesh Vutla Nov. 22, 2019, 10:03 a.m. UTC
Add power-domains entry for smmu, so that the it is accessible as long
as the driver is active. Without this device shutdown is throwing the
below warning:
"[   44.736348] arm-smmu-v3 36600000.smmu: failed to clear cr0"

Reported-by: Suman Anna <s-anna@ti.com>
Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
---
 arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Lokesh Vutla Jan. 6, 2020, 4 a.m. UTC | #1
H Tero,

On 22/11/19 3:33 PM, Lokesh Vutla wrote:
> Add power-domains entry for smmu, so that the it is accessible as long
> as the driver is active. Without this device shutdown is throwing the
> below warning:
> "[   44.736348] arm-smmu-v3 36600000.smmu: failed to clear cr0"
> 
> Reported-by: Suman Anna <s-anna@ti.com>
> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>

Any comments on this patch? If there are no objections, can this be picked?

Thanks and regards,
Lokesh

> ---
>  arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> index 698ef9a1d5b7..96445111e398 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
> @@ -43,6 +43,7 @@
>  	smmu0: smmu@36600000 {
>  		compatible = "arm,smmu-v3";
>  		reg = <0x0 0x36600000 0x0 0x100000>;
> +		power-domains = <&k3_pds 229 TI_SCI_PD_EXCLUSIVE>;
>  		interrupt-parent = <&gic500>;
>  		interrupts = <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>,
>  			     <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>;
>
Tero Kristo Jan. 17, 2020, 12:58 p.m. UTC | #2
On 06/01/2020 06:00, Lokesh Vutla wrote:
> H Tero,
> 
> On 22/11/19 3:33 PM, Lokesh Vutla wrote:
>> Add power-domains entry for smmu, so that the it is accessible as long
>> as the driver is active. Without this device shutdown is throwing the
>> below warning:
>> "[   44.736348] arm-smmu-v3 36600000.smmu: failed to clear cr0"
>>
>> Reported-by: Suman Anna <s-anna@ti.com>
>> Signed-off-by: Lokesh Vutla <lokeshvutla@ti.com>
> 
> Any comments on this patch? If there are no objections, can this be picked?

Sorry for delay, I've been engulfed with various other pieces of work 
and handling upstream has been quite slow.

Anyways, for this patch, queued up for 5.6, thanks!

-Tero

> 
> Thanks and regards,
> Lokesh
> 
>> ---
>>   arch/arm64/boot/dts/ti/k3-j721e-main.dtsi | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
>> index 698ef9a1d5b7..96445111e398 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
>> @@ -43,6 +43,7 @@
>>   	smmu0: smmu@36600000 {
>>   		compatible = "arm,smmu-v3";
>>   		reg = <0x0 0x36600000 0x0 0x100000>;
>> +		power-domains = <&k3_pds 229 TI_SCI_PD_EXCLUSIVE>;
>>   		interrupt-parent = <&gic500>;
>>   		interrupts = <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>,
>>   			     <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>;
>>

--
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
index 698ef9a1d5b7..96445111e398 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721e-main.dtsi
@@ -43,6 +43,7 @@ 
 	smmu0: smmu@36600000 {
 		compatible = "arm,smmu-v3";
 		reg = <0x0 0x36600000 0x0 0x100000>;
+		power-domains = <&k3_pds 229 TI_SCI_PD_EXCLUSIVE>;
 		interrupt-parent = <&gic500>;
 		interrupts = <GIC_SPI 772 IRQ_TYPE_EDGE_RISING>,
 			     <GIC_SPI 768 IRQ_TYPE_EDGE_RISING>;