| Message ID | 20191206125112.11006-1-m.szyprowski@samsung.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 18977008f44c66bdd6d20bb432adf71372589303 |
| Headers | show |
| Series | arm: multi_v7_config: Restore debugfs support | expand |
On Fri, Dec 6, 2019 at 4:51 AM Marek Szyprowski <m.szyprowski@samsung.com> wrote: > > Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent > additions") removed explicit enable line for CONFIG_DEBUG_FS, because > that feature has been selected by other enabled options: CONFIG_TRACING, > which were enabled by CONFIG_PERF_EVENTS. > > In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS > dependency") removed the dependency between CONFIG_DEBUG_FS and > CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds. > > Enable it again explicitly, as debugfs support is essential for various > automated testing tools. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Please cc patches you want us to apply to soc@kernel.org (and, if you want, arm@kernel.org). Applying. Thanks! -Olof
Hi Marek, On Fri, Dec 6, 2019 at 1:51 PM Marek Szyprowski <m.szyprowski@samsung.com> wrote: > Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent > additions") removed explicit enable line for CONFIG_DEBUG_FS, because > that feature has been selected by other enabled options: CONFIG_TRACING, > which were enabled by CONFIG_PERF_EVENTS. > > In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS > dependency") removed the dependency between CONFIG_DEBUG_FS and > CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds. > > Enable it again explicitly, as debugfs support is essential for various > automated testing tools. ... and for systemd :-( E.g. with Debian 9 nfsroot: [FAILED] Failed to mount /sys/kernel/debug. See 'systemctl status sys-kernel-debug.mount' for details. [DEPEND] Dependency failed for Local File Systems. ... You are in emergGive root password for maintenance (or press Control-D to continue): > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Thank you! Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> This is gonna bite lots of people (and defconfigs)... Gr{oetje,eeting}s, Geert
+Kevin, since this seems like something ideally we would see some coverage of from Kernel CI at some point. On Mon, Dec 9, 2019 at 1:29 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > Hi Marek, > > On Fri, Dec 6, 2019 at 1:51 PM Marek Szyprowski > <m.szyprowski@samsung.com> wrote: > > Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent > > additions") removed explicit enable line for CONFIG_DEBUG_FS, because > > that feature has been selected by other enabled options: CONFIG_TRACING, > > which were enabled by CONFIG_PERF_EVENTS. > > > > In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS > > dependency") removed the dependency between CONFIG_DEBUG_FS and > > CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds. > > > > Enable it again explicitly, as debugfs support is essential for various > > automated testing tools. > > ... and for systemd :-( > > E.g. with Debian 9 nfsroot: > > [FAILED] Failed to mount /sys/kernel/debug. > See 'systemctl status sys-kernel-debug.mount' for details. > [DEPEND] Dependency failed for Local File Systems. > ... > You are in emergGive root password for maintenance > (or press Control-D to continue): > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > Thank you! > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > This is gonna bite lots of people (and defconfigs)... Looks like the in-tree affected defconfigs are: olof@quad:~/work/arm-soc/arch/arm/configs (for-next) $ fgrep -L CONFIG_DEBUG_FS $(fgrep -l CONFIG_PERF_EVENTS *) aspeed_g4_defconfig aspeed_g5_defconfig exynos_defconfig imx_v6_v7_defconfig milbeaut_m10v_defconfig mvebu_v7_defconfig mxs_defconfig oxnas_v6_defconfig shmobile_defconfig tegra_defconfig olof@quad:~/work/arm-soc/arch/arm/configs (for-next) $ I'll revisit with patches for those later today. -Olof
On Mon, 9 Dec 2019 at 18:45, Olof Johansson <olof@lixom.net> wrote: > > +Kevin, since this seems like something ideally we would see some > coverage of from Kernel CI at some point. > > > On Mon, Dec 9, 2019 at 1:29 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote: > > > > Hi Marek, > > > > On Fri, Dec 6, 2019 at 1:51 PM Marek Szyprowski > > <m.szyprowski@samsung.com> wrote: > > > Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent > > > additions") removed explicit enable line for CONFIG_DEBUG_FS, because > > > that feature has been selected by other enabled options: CONFIG_TRACING, > > > which were enabled by CONFIG_PERF_EVENTS. > > > > > > In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS > > > dependency") removed the dependency between CONFIG_DEBUG_FS and > > > CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds. > > > > > > Enable it again explicitly, as debugfs support is essential for various > > > automated testing tools. > > > > ... and for systemd :-( > > > > E.g. with Debian 9 nfsroot: > > > > [FAILED] Failed to mount /sys/kernel/debug. > > See 'systemctl status sys-kernel-debug.mount' for details. > > [DEPEND] Dependency failed for Local File Systems. > > ... > > You are in emergGive root password for maintenance > > (or press Control-D to continue): > > > > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > > > > Thank you! > > > > Acked-by: Geert Uytterhoeven <geert+renesas@glider.be> > > > > This is gonna bite lots of people (and defconfigs)... > > Looks like the in-tree affected defconfigs are: > > olof@quad:~/work/arm-soc/arch/arm/configs (for-next) $ fgrep -L > CONFIG_DEBUG_FS $(fgrep -l CONFIG_PERF_EVENTS *) > aspeed_g4_defconfig > aspeed_g5_defconfig > exynos_defconfig I picked up already Marek's patch for exynos_defconfig. Best regards, Krzysztof
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 24962d0e71c7..0ffa957f2c94 100644 --- a/arch/arm/configs/multi_v7_defconfig +++ b/arch/arm/configs/multi_v7_defconfig @@ -1121,3 +1121,4 @@ CONFIG_CRYPTO_DEV_ROCKCHIP=m CONFIG_CMA_SIZE_MBYTES=64 CONFIG_PRINTK_TIME=y CONFIG_MAGIC_SYSRQ=y +CONFIG_DEBUG_FS=y
Commit fd7d58f0dbc3 ("ARM: multi_v7_defconfig: renormalize based on recent additions") removed explicit enable line for CONFIG_DEBUG_FS, because that feature has been selected by other enabled options: CONFIG_TRACING, which were enabled by CONFIG_PERF_EVENTS. In meantime, commit 0e4a459f56c3 ("tracing: Remove unnecessary DEBUG_FS dependency") removed the dependency between CONFIG_DEBUG_FS and CONFIG_TRACING, so CONFIG_DEBUG_FS is no longer enabled in default builds. Enable it again explicitly, as debugfs support is essential for various automated testing tools. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+)