From patchwork Wed Dec 11 19:27:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brendan Higgins X-Patchwork-Id: 11286155 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 1D95D14BD for ; Wed, 11 Dec 2019 19:28:59 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EFD8520836 for ; Wed, 11 Dec 2019 19:28:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Brn217F3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="hk5XU7cU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EFD8520836 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:From:Subject:References:Mime-Version :Message-Id:In-Reply-To:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=fnshS0HhbVrDb5iWzmgd53Dub4XGaQJlpV+MdOScmpM=; b=Brn217F3HAA7Sq PRmcSaOiE0WGW0lUE+TJrg7PcwA4ESi+wZW3pnAgJ19PbHRq2FSf6SIgY8j4Z3bpLJXVRhjm2GB6w TqdAwByIHAmGlu0jxOECZclCkmBTUU5jy+v2vC5OSRAOY0e9XBId+YxOiF5GOUvSeDNyYuMwQjBKY l84y4J8KY2/HoOUxJwaOe9wZ/kQkenm5nrnc60wdA2j6Q/ghZN/SrICWlojmcBqDtBSV4PRHFSOE4 4KWmTOsFCLiVy+vxFxMauKBxV03ySRA2SkLYBo6lpqF4JNE0/ujchWRPJkJfZ6OOhmVTqyKASFvIZ ZQRQna7wt4e0T7riYRVg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1if7fL-0004zo-44; Wed, 11 Dec 2019 19:28:55 +0000 Received: from mail-ua1-x949.google.com ([2607:f8b0:4864:20::949]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1if7eh-0004Ji-Fd for linux-arm-kernel@lists.infradead.org; Wed, 11 Dec 2019 19:28:17 +0000 Received: by mail-ua1-x949.google.com with SMTP id 108so6471390uad.11 for ; Wed, 11 Dec 2019 11:28:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=RQFDo13VZRdiKwc/pVrHKJHbLovklfvTM/XI87MZyHc=; b=hk5XU7cUaCcQ0Nde+eT5cb/6qwUvOjqFutXP7PRicgzyIGfK7KSbsZII98DfGIn2FW dtQymELG0GrhacSnYHQp3RHByaT46VfTyG6tnTl4Jsk836X8X+fyiDg1vDM0umT5oppm UgVIqhFFhkz4LTwJvtJFgchjlga2R0OupRlXvw3oko/W+1K9fRHoYDgICYr3QjciF1hv 60PjkiTLGt5xA3chP4Yx0vIchU/ZZ3iaMRNuguxvUHnFe1WEFaZso9+eBFcxLjuV0NVZ /07928V8wcKVNcx4O0aZhvCWDioa2HlcD1rankvFdc0518jUklNNTHG92Y9KtstUiOND P6JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=RQFDo13VZRdiKwc/pVrHKJHbLovklfvTM/XI87MZyHc=; b=Q9cIMG9vNiBzaDZ9MwS7JfbPu+dRjb4XTCvm4J5q/3E5s4coABzicUpeAmYlT/K6Ax tOrx/zUctwWAKfMlilgeDPKuJBw27EM1EiLHEsr7ReE+z2uxaXvtZmAQ+88AjfIOTUb5 HHckQb2Qsnmpb9AEC70pan55smnXqSEIDS5EKeMbcY0eIYfk3cJOKo9wiz0e/B+cgc+d bCrFrnE/nYZJS+3Uu/qvrZmOOUOcMhFIVFeGgpJRv9IEm5D6mym2X9vNKF6Zr1+BQLOm yM8MsshQJAChbJPTWyRlRyKiDbHHOHnYid+iMI1mWdeUUX88ppk/kzLwyfOuXuNNh7Ch mdZQ== X-Gm-Message-State: APjAAAWzkIizqypPkEWlLVXoZKdw2LyaRHGszBDZsk6JqaMk73Yv9ZIT 3orUfTxwt+zlCvUCtkh2O2AjBrzKJBlVN8xMEUWY0g== X-Google-Smtp-Source: APXvYqxn1i43i48Jqfr6hVocDDO1DiINGbV0G5JeKpjCv8KvGUu2v9FiOXP9TMA8RDO8XOUYwG4WIpJMJNZpSQ90pHgIUg== X-Received: by 2002:a1f:6103:: with SMTP id v3mr5185450vkb.60.1576092492825; Wed, 11 Dec 2019 11:28:12 -0800 (PST) Date: Wed, 11 Dec 2019 11:27:38 -0800 In-Reply-To: <20191211192742.95699-1-brendanhiggins@google.com> Message-Id: <20191211192742.95699-4-brendanhiggins@google.com> Mime-Version: 1.0 References: <20191211192742.95699-1-brendanhiggins@google.com> X-Mailer: git-send-email 2.24.0.525.g8f36a354ae-goog Subject: [PATCH v1 3/7] net: axienet: add unspecified HAS_IOMEM dependency From: Brendan Higgins To: jdike@addtoit.com, richard@nod.at, anton.ivanov@cambridgegreys.com, "David S. Miller" , Michal Simek , Radhey Shyam Pandey X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191211_112815_622505_4292E409 X-CRM114-Status: UNSURE ( 9.82 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -7.7 (-------) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-7.7 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2607:f8b0:4864:20:0:0:0:949 listed in] [list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -7.5 USER_IN_DEF_DKIM_WL From: address is in the default DKIM white-list -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.0 DKIMWL_WL_MED DKIMwl.org - Medium sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-um@lists.infradead.org, Brendan Higgins , linux-kernel@vger.kernel.org, davidgow@google.com, netdev@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Currently CONFIG_XILINX_AXI_EMAC=y implicitly depends on CONFIG_HAS_IOMEM=y; consequently, on architectures without IOMEM we get the following build error: ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.o: in function `axienet_probe': drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1680: undefined reference to `devm_ioremap_resource' ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1779: undefined reference to `devm_ioremap_resource' ld: drivers/net/ethernet/xilinx/xilinx_axienet_main.c:1789: undefined reference to `devm_ioremap_resource' Fix the build error by adding the unspecified dependency. Reported-by: Brendan Higgins Signed-off-by: Brendan Higgins Reviewed-by: Radhey Shyam Pandey --- drivers/net/ethernet/xilinx/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/ethernet/xilinx/Kconfig b/drivers/net/ethernet/xilinx/Kconfig index 6304ebd8b5c69..b1a285e693756 100644 --- a/drivers/net/ethernet/xilinx/Kconfig +++ b/drivers/net/ethernet/xilinx/Kconfig @@ -25,6 +25,7 @@ config XILINX_EMACLITE config XILINX_AXI_EMAC tristate "Xilinx 10/100/1000 AXI Ethernet support" + depends on HAS_IOMEM select PHYLINK ---help--- This driver supports the 10/100/1000 Ethernet from Xilinx for the