From patchwork Thu Dec 19 09:39:54 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomasz Figa X-Patchwork-Id: 11302925 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CDA16921 for ; Thu, 19 Dec 2019 09:40:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7E6B24679 for ; Thu, 19 Dec 2019 09:40:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="TibT0Fiq"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LyDg1/Lf" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A7E6B24679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=5DibmmMD+74qcd/qRMx/eoapAGZphaXzmUbCti4Yqks=; b=TibT0Fiq+5ck7p gVWFEBzGaadnXS/3BnZ4JFqpzaZrZFPKy9vRCqrQy69hGXObbpaXkIaF3o61kgoFq9lex6OA1X8kG uhRHUVM/iNX2QKZPaX2wwH1KSCYHYyLJ1hqYKGqnUc+Joido6OcCFB9k6FygXVcSU8pBbT3WWMyyg ZJin6JgYAqaH/TG+lt4p6fxElPhGCZw2G9ZlSUIzx2PgNSiLPqOH8BKsM8AAkz7zklvbLX3Eda8RQ N7/NnnLFgwFXJjdoFzo/fExCtDdAw5gg/k6pdgpW7ZWtKY2xIEOxkPiJge7R9kid0leyaCDpmE2it ye6AZbKj7tVOYsTZEwKQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihsI0-00014L-Ux; Thu, 19 Dec 2019 09:40:12 +0000 Received: from mail-pj1-x1043.google.com ([2607:f8b0:4864:20::1043]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1ihsHx-0000lc-En for linux-arm-kernel@lists.infradead.org; Thu, 19 Dec 2019 09:40:11 +0000 Received: by mail-pj1-x1043.google.com with SMTP id s94so2376377pjc.1 for ; Thu, 19 Dec 2019 01:40:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UaU6i9zWU3yr9QJvcRz0VGGzrcUKaBIv86YipeMOKo8=; b=LyDg1/LfFyRwWJTxBF/LnsfrTJSpgla5kvA98Hg+eeijCP9Q4VYEvCBGyN5xVxKn7p eEsQscd3wujq8XMHgepAaRQXBH0E1PQZo9FaDL3lWv8qT+wBABdwjQ6wBRbPQczrwZhV xi1HLrIQxvVPsnnXebX2B39JQ8NlNTXox5+ak= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=UaU6i9zWU3yr9QJvcRz0VGGzrcUKaBIv86YipeMOKo8=; b=KvS/sX6gVeU3DWtlTtI5g3DuDQAyx395PLVouvKTjqXxD9K23+Z6efigAR5eEp0N7T Q54P3pmSsvbosO7pdfjeduCRrBrE779f8+JNG4cuOja24wrK/RNExuuoSw66L2HD1Gih qr0Z3XxytcdjMATTlkfm+0UaHOipkp0JsOHCIBuRId5nADv24wwOVSOA2HVXh7QuSc86 yXVM179QE1l7yY0zdmkor678PfGmXrfF9H/jGwnkUVNFL2s6fA1+2PyDoUuCS7DOGZvF A9ykNWUlhX0oc07maKfzWt1gOvIWxl93h6YrGdziEJSV2NaO2ITu8VY2BmJ2DzGemZOP PqHQ== X-Gm-Message-State: APjAAAWQ3Bbp0Fw96Q+SsJJzX6OjFf706baGbGRdBoTz3b4qJAzeCSNL JeHKD6W+xFh/Aa+g04/kJtUiPA== X-Google-Smtp-Source: APXvYqzL4Uv3f/vYWiTWGoQqppzSjCV/VAXe3mUM5lmKJDJ2u9Tql+pWQk6EMSv57P1oNg9ofZmndA== X-Received: by 2002:a17:902:8bc5:: with SMTP id r5mr8257114plo.189.1576748408099; Thu, 19 Dec 2019 01:40:08 -0800 (PST) Received: from tfiga.tok.corp.google.com ([2401:fa00:8f:203:f5fe:2a5e:f953:c0ed]) by smtp.gmail.com with ESMTPSA id d22sm7057694pfo.187.2019.12.19.01.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Dec 2019 01:40:07 -0800 (PST) From: Tomasz Figa To: linux-usb@vger.kernel.org Subject: [PATCH] usb: mtk-xhci: Do not explicitly set the DMA mask Date: Thu, 19 Dec 2019 18:39:54 +0900 Message-Id: <20191219093954.163417-1-tfiga@chromium.org> X-Mailer: git-send-email 2.24.1.735.g03f4e72817-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191219_014009_529119_883989CB X-CRM114-Status: GOOD ( 11.31 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.2 on bombadil.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.0 DKIMWL_WL_HIGH DKIMwl.org - Whitelisted High sender X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Boichat , Changqi Hu , Mathias Nyman , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, Tomasz Figa , Matthias Brugger , Shik Chen , linux-mediatek@lists.infradead.org, Chunfeng Yun , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org The mtk-xhci platform glue sets the DMA mask to 32 bits on its own, which was needed before commit fda182d80a0b ("usb: xhci: configure 32-bit DMA if the controller does not support 64-bit DMA"), but now it has no effect, because xhci_gen_setup() sets it up for us according to hardware capabilities. Remove the useless code. Signed-off-by: Tomasz Figa --- drivers/usb/host/xhci-mtk.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c index b18a6baef204a..bfbdb3ceed291 100644 --- a/drivers/usb/host/xhci-mtk.c +++ b/drivers/usb/host/xhci-mtk.c @@ -488,11 +488,6 @@ static int xhci_mtk_probe(struct platform_device *pdev) goto disable_clk; } - /* Initialize dma_mask and coherent_dma_mask to 32-bits */ - ret = dma_set_mask_and_coherent(dev, DMA_BIT_MASK(32)); - if (ret) - goto disable_clk; - hcd = usb_create_hcd(driver, dev, dev_name(dev)); if (!hcd) { ret = -ENOMEM;