| Message ID | 20200106191003.21584-1-tiny.windzz@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/2] ARM: dts: exynos: tiny4412: add fimd node | expand |
On Mon, Jan 06, 2020 at 07:10:02PM +0000, Yangtao Li wrote: > The patch adds fimd node for tiny4412 device. Hi, Thanks for the patch. Do not use "This patch ..." sentences but simple, imperative mode: https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 Here you do not add FIMD node, because the FIMD is already there (defined in exynos4.dtsi). You however enable it. Enabling it without panel does not really make sense - does it work? I guess not, so this should be squashed with second patch. Best regards, Krzysztof > > Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> > --- > arch/arm/boot/dts/exynos4412-tiny4412.dts | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts > index 01f37b5ac9c4..2b62cb27420c 100644 > --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts > +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts > @@ -68,6 +68,14 @@ > }; > }; > > +&fimd { > + pinctrl-0 = <&lcd_clk>, <&lcd_data24>; > + pinctrl-names = "default"; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "okay"; > +}; > + > &rtc { > status = "okay"; > }; > -- > 2.17.1 >
On Tue, 7 Jan 2020 at 09:45, Krzysztof Kozlowski <krzk@kernel.org> wrote: > > On Mon, Jan 06, 2020 at 07:10:02PM +0000, Yangtao Li wrote: > > The patch adds fimd node for tiny4412 device. > > Hi, > > Thanks for the patch. > > Do not use "This patch ..." sentences but simple, imperative mode: > https://elixir.bootlin.com/linux/latest/source/Documentation/process/submitting-patches.rst#L151 > > Here you do not add FIMD node, because the FIMD is already there > (defined in exynos4.dtsi). You however enable it. > > Enabling it without panel does not really make sense - does it work? > I guess not, so this should be squashed with second patch. ... unless it really works without panel, then it makes sense to keep it separate. However in such case, the #cells properties belong to second patch. Best regards, Krzysztof
diff --git a/arch/arm/boot/dts/exynos4412-tiny4412.dts b/arch/arm/boot/dts/exynos4412-tiny4412.dts index 01f37b5ac9c4..2b62cb27420c 100644 --- a/arch/arm/boot/dts/exynos4412-tiny4412.dts +++ b/arch/arm/boot/dts/exynos4412-tiny4412.dts @@ -68,6 +68,14 @@ }; }; +&fimd { + pinctrl-0 = <&lcd_clk>, <&lcd_data24>; + pinctrl-names = "default"; + #address-cells = <1>; + #size-cells = <0>; + status = "okay"; +}; + &rtc { status = "okay"; };
The patch adds fimd node for tiny4412 device. Signed-off-by: Yangtao Li <tiny.windzz@gmail.com> --- arch/arm/boot/dts/exynos4412-tiny4412.dts | 8 ++++++++ 1 file changed, 8 insertions(+)