| Message ID | 20200106193053.2884-1-clabbe.montjoie@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 93d24ac4b26770f8e5118a731cd9314f3808bd10 |
| Headers | show |
| Series | crypto: sun8i-ce: fix removal of module | expand |
On Mon, Jan 06, 2020 at 08:30:53PM +0100, Corentin Labbe wrote: > Removing the driver cause an oops due to the fact we clean an extra > channel. > Let's give the right index to the cleaning function. > > Fixes: 06f751b61329 ("crypto: allwinner - Add sun8i-ce Crypto Engine") > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> > --- > drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks.
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c index 53739507c8c2..f72346a44e69 100644 --- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c +++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c @@ -624,7 +624,7 @@ static int sun8i_ce_probe(struct platform_device *pdev) error_irq: sun8i_ce_pm_exit(ce); error_pm: - sun8i_ce_free_chanlist(ce, MAXFLOW); + sun8i_ce_free_chanlist(ce, MAXFLOW - 1); return err; } @@ -638,7 +638,7 @@ static int sun8i_ce_remove(struct platform_device *pdev) debugfs_remove_recursive(ce->dbgfs_dir); #endif - sun8i_ce_free_chanlist(ce, MAXFLOW); + sun8i_ce_free_chanlist(ce, MAXFLOW - 1); sun8i_ce_pm_exit(ce); return 0;
Removing the driver cause an oops due to the fact we clean an extra channel. Let's give the right index to the cleaning function. Fixes: 06f751b61329 ("crypto: allwinner - Add sun8i-ce Crypto Engine") Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com> --- drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)