diff mbox series

[RFC,v5,01/57] objtool: check: Remove redundant checks on operand type

Message ID 20200109160300.26150-2-jthierry@redhat.com (mailing list archive)
State New, archived
Headers show
Series objtool: Add support for arm64 | expand

Commit Message

Julien Thierry Jan. 9, 2020, 4:02 p.m. UTC 
POP operations are already in code path where destination operand
is OP_DEST_REG. There is no need to check the operand type again.

Signed-off-by: Julien Thierry <jthierry@redhat.com>
---
 tools/objtool/check.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

--
2.21.0
diff mbox series

Patch

diff --git a/tools/objtool/check.c b/tools/objtool/check.c
index 4768d91c6d68..a04778421144 100644
--- a/tools/objtool/check.c
+++ b/tools/objtool/check.c
@@ -1672,15 +1672,13 @@  static int update_insn_state(struct instruction *insn, struct insn_state *state)

 		case OP_SRC_POP:
 		case OP_SRC_POPF:
-			if (!state->drap && op->dest.type == OP_DEST_REG &&
-			    op->dest.reg == cfa->base) {
+			if (!state->drap && op->dest.reg == cfa->base) {

 				/* pop %rbp */
 				cfa->base = CFI_SP;
 			}

 			if (state->drap && cfa->base == CFI_BP_INDIRECT &&
-			    op->dest.type == OP_DEST_REG &&
 			    op->dest.reg == state->drap_reg &&
 			    state->drap_offset == -state->stack_size) {