diff mbox series

[v1,1/1] pinctrl: iproc: Use platform_get_irq_optional() to avoid error message

Message ID 20200110035524.23511-1-rayagonda.kokatanur@broadcom.com (mailing list archive)
State Mainlined
Commit 783e998653b430a159f83552fa263f57bf8e2055
Headers show
Series [v1,1/1] pinctrl: iproc: Use platform_get_irq_optional() to avoid error message | expand

Commit Message

Rayagonda Kokatanur Jan. 10, 2020, 3:55 a.m. UTC
Use platform_get_irq_optional() instead of platform_get_irq() to avoid
below error message during probe:

[ 0.589121] iproc-gpio 66424800.gpio: IRQ index 0 not found

Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
---
 drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Chris Packham Jan. 12, 2020, 8 p.m. UTC | #1
On Fri, 2020-01-10 at 09:25 +0530, Rayagonda Kokatanur wrote:
> Use platform_get_irq_optional() instead of platform_get_irq() to avoid
> below error message during probe:
> 
> [ 0.589121] iproc-gpio 66424800.gpio: IRQ index 0 not found
> 
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>

Reviewed-by: Chris Packham <chris.packham@alliedtelesis.co.nz>

> ---
>  drivers/pinctrl/bcm/pinctrl-iproc-gpio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> index 831a9318c384..0d2bdb818d41 100644
> --- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> +++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
> @@ -843,7 +843,7 @@ static int iproc_gpio_probe(struct platform_device *pdev)
>  							"gpio-ranges");
>  
>  	/* optional GPIO interrupt support */
> -	irq = platform_get_irq(pdev, 0);
> +	irq = platform_get_irq_optional(pdev, 0);
>  	if (irq > 0) {
>  		struct irq_chip *irqc;
>  		struct gpio_irq_chip *girq;
Linus Walleij Jan. 15, 2020, 12:46 p.m. UTC | #2
On Fri, Jan 10, 2020 at 4:55 AM Rayagonda Kokatanur
<rayagonda.kokatanur@broadcom.com> wrote:

> Use platform_get_irq_optional() instead of platform_get_irq() to avoid
> below error message during probe:
>
> [ 0.589121] iproc-gpio 66424800.gpio: IRQ index 0 not found
>
> Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>

Patch applied with Chris' ACK.

Yours,
Linus Walleij
diff mbox series

Patch

diff --git a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
index 831a9318c384..0d2bdb818d41 100644
--- a/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
+++ b/drivers/pinctrl/bcm/pinctrl-iproc-gpio.c
@@ -843,7 +843,7 @@  static int iproc_gpio_probe(struct platform_device *pdev)
 							"gpio-ranges");
 
 	/* optional GPIO interrupt support */
-	irq = platform_get_irq(pdev, 0);
+	irq = platform_get_irq_optional(pdev, 0);
 	if (irq > 0) {
 		struct irq_chip *irqc;
 		struct gpio_irq_chip *girq;