| Message ID | 20200217191503.31444-1-festevam@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 26c4b4758fce8f0ae744335e1762213be29db441 |
| Headers | show |
| Series | arm64: dts: imx8qxp-mek: Remove unexisting Ethernet PHY | expand |
On 17.02.2020 21:15, Fabio Estevam wrote: > There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek. > > Remove the unexisting ethphy1 port. > > This fixes a run-time warning: > > mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing. > > Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support") > Signed-off-by: Fabio Estevam <festevam@gmail.com> +Andy I remember that it's possible to get a second ethernet port through a baseboard on imx8qxp. It's not a default option but it's real. Unless I'm missing something? > --- > arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > index d3d26cca7d52..13460a360c6a 100644 > --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > @@ -52,11 +52,6 @@ > compatible = "ethernet-phy-ieee802.3-c22"; > reg = <0>; > }; > - > - ethphy1: ethernet-phy@1 { > - compatible = "ethernet-phy-ieee802.3-c22"; > - reg = <1>; > - }; > }; > }; > >
From: Leonard Crestez <leonard.crestez@nxp.com> Sent: Tuesday, February 18, 2020 4:10 AM > On 17.02.2020 21:15, Fabio Estevam wrote: > > There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek. > > > > Remove the unexisting ethphy1 port. > > > > This fixes a run-time warning: > > > > mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing. > > > > Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support") > > Signed-off-by: Fabio Estevam <festevam@gmail.com> > > +Andy > > I remember that it's possible to get a second ethernet port through a > baseboard on imx8qxp. It's not a default option but it's real. > > Unless I'm missing something? Yes, the phy is attached to second net device that is on baseboard. Because there have pin conflict with esai0, there have another extra dts file for it. Andy > > > --- > > arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > > b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > > index d3d26cca7d52..13460a360c6a 100644 > > --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > > +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts > > @@ -52,11 +52,6 @@ > > compatible = "ethernet-phy-ieee802.3-c22"; > > reg = <0>; > > }; > > - > > - ethphy1: ethernet-phy@1 { > > - compatible = "ethernet-phy-ieee802.3-c22"; > > - reg = <1>; > > - }; > > }; > > }; > > > >
On 18.02.2020 06:55, Andy Duan wrote: > From: Leonard Crestez <leonard.crestez@nxp.com> Sent: Tuesday, February 18, 2020 4:10 AM >> On 17.02.2020 21:15, Fabio Estevam wrote: >>> There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek. >>> >>> Remove the unexisting ethphy1 port. >>> >>> This fixes a run-time warning: >>> >>> mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing. >>> >>> Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support") >>> Signed-off-by: Fabio Estevam <festevam@gmail.com> >> >> +Andy >> >> I remember that it's possible to get a second ethernet port through a >> baseboard on imx8qxp. It's not a default option but it's real. >> >> Unless I'm missing something? > > Yes, the phy is attached to second net device that is on baseboard. > Because there have pin conflict with esai0, there have another extra > dts file for it. Then it would be reasonable to remove ethphy1 from main dts and add it back in -enet2.dts (which is not yet in upstream) So Fabio's patch is correct. Reviewed-by: Leonard Crestez <leonard.crestez@nxp.com> >>> --- >>> arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 ----- >>> 1 file changed, 5 deletions(-) >>> >>> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts >>> b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts >>> index d3d26cca7d52..13460a360c6a 100644 >>> --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts >>> +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts >>> @@ -52,11 +52,6 @@ >>> compatible = "ethernet-phy-ieee802.3-c22"; >>> reg = <0>; >>> }; >>> - >>> - ethphy1: ethernet-phy@1 { >>> - compatible = "ethernet-phy-ieee802.3-c22"; >>> - reg = <1>; >>> - }; >>> }; >>> };
On Mon, Feb 17, 2020 at 04:15:03PM -0300, Fabio Estevam wrote: > There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek. > > Remove the unexisting ethphy1 port. > > This fixes a run-time warning: > > mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing. > > Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support") > Signed-off-by: Fabio Estevam <festevam@gmail.com> Applied, thanks.
diff --git a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts index d3d26cca7d52..13460a360c6a 100644 --- a/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts +++ b/arch/arm64/boot/dts/freescale/imx8qxp-mek.dts @@ -52,11 +52,6 @@ compatible = "ethernet-phy-ieee802.3-c22"; reg = <0>; }; - - ethphy1: ethernet-phy@1 { - compatible = "ethernet-phy-ieee802.3-c22"; - reg = <1>; - }; }; };
There is only on Ethernet port and one Ethernet PHY on imx8qxp-mek. Remove the unexisting ethphy1 port. This fixes a run-time warning: mdio_bus 5b040000.ethernet-1: MDIO device at address 1 is missing. Fixes: fdea904e85e1 ("arm64: dts: imx: add imx8qxp mek support") Signed-off-by: Fabio Estevam <festevam@gmail.com> --- arch/arm64/boot/dts/freescale/imx8qxp-mek.dts | 5 ----- 1 file changed, 5 deletions(-)