| Message ID | 20200222235152.242816-1-megous@megous.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drm: aspeed: Fix GENMASK misuse | expand |
On Sun, 23 Feb 2020, at 10:21, Ondrej Jirman wrote: > Arguments to GENMASK should be msb >= lsb. > > Signed-off-by: Ondrej Jirman <megous@megous.com> > --- > I just grepped the whole kernel tree for GENMASK argument order issues, > and this is one of the three that popped up. No testing was done. I think someone's sent a patch previously, and last time it turned into a discussion about how the macros aren't actually used and could be removed. Regardless: Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
On Mon, 24 Feb 2020 at 00:06, Andrew Jeffery <andrew@aj.id.au> wrote: > > > > On Sun, 23 Feb 2020, at 10:21, Ondrej Jirman wrote: > > Arguments to GENMASK should be msb >= lsb. > > > > Signed-off-by: Ondrej Jirman <megous@megous.com> > > --- > > I just grepped the whole kernel tree for GENMASK argument order issues, > > and this is one of the three that popped up. No testing was done. > > I think someone's sent a patch previously, and last time it turned into a > discussion about how the macros aren't actually used and could be > removed. > > Regardless: > > Reviewed-by: Andrew Jeffery <andrew@aj.id.au> Thanks, I've applied this to drm-misc-next. Apologies for the delay.
diff --git a/drivers/gpu/drm/aspeed/aspeed_gfx.h b/drivers/gpu/drm/aspeed/aspeed_gfx.h index a10358bb61ec4..095ea03e5833c 100644 --- a/drivers/gpu/drm/aspeed/aspeed_gfx.h +++ b/drivers/gpu/drm/aspeed/aspeed_gfx.h @@ -74,7 +74,7 @@ int aspeed_gfx_create_output(struct drm_device *drm); /* CTRL2 */ #define CRT_CTRL_DAC_EN BIT(0) #define CRT_CTRL_VBLANK_LINE(x) (((x) << 20) & CRT_CTRL_VBLANK_LINE_MASK) -#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(20, 31) +#define CRT_CTRL_VBLANK_LINE_MASK GENMASK(31, 20) /* CRT_HORIZ0 */ #define CRT_H_TOTAL(x) (x)
Arguments to GENMASK should be msb >= lsb. Signed-off-by: Ondrej Jirman <megous@megous.com> --- I just grepped the whole kernel tree for GENMASK argument order issues, and this is one of the three that popped up. No testing was done. drivers/gpu/drm/aspeed/aspeed_gfx.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)