| Message ID | 20200223104019.527587-1-megous@megous.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 3abe422fdc65ba08054659b0d27c71e24346021d |
| Headers | show |
| Series | [v2] arm64: dts: sun50i-h5-orange-pi-pc2: Add CPUX voltage regulator | expand |
On Sun, Feb 23, 2020 at 11:40:19AM +0100, Ondrej Jirman wrote: > Orange Pi PC2 features sy8106a regulator just like Orange Pi PC. > > Signed-off-by: Ondrej Jirman <megous@megous.com> > Reviewed-by: Samuel Holland <samuel@sholland.org> > --- > .../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 20 +++++++++++++++++++ > 1 file changed, 20 insertions(+) Having a changelog would be great > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts > index 70b5f09984218..7b2572dc84857 100644 > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts > @@ -93,6 +93,10 @@ &codec { > status = "okay"; > }; > > +&cpu0 { > + cpu-supply = <®_vdd_cpux>; > +}; > + > &de { > status = "okay"; > }; > @@ -168,6 +172,22 @@ &ohci3 { > status = "okay"; > }; > > +&r_i2c { > + status = "okay"; > + > + reg_vdd_cpux: regulator@65 { > + compatible = "silergy,sy8106a"; > + reg = <0x65>; > + regulator-name = "vdd-cpux"; > + silergy,fixed-microvolt = <1100000>; > + regulator-min-microvolt = <1000000>; > + regulator-max-microvolt = <1400000>; > + regulator-ramp-delay = <200>; > + regulator-boot-on; > + regulator-always-on; > + }; > +}; > + Looks like you fixed the issues reported by Samuel though. I've applied it. Maxime
On Mon, Feb 24, 2020 at 10:27:04AM +0100, Maxime Ripard wrote: > On Sun, Feb 23, 2020 at 11:40:19AM +0100, Ondrej Jirman wrote: > > Orange Pi PC2 features sy8106a regulator just like Orange Pi PC. > > > > Signed-off-by: Ondrej Jirman <megous@megous.com> > > Reviewed-by: Samuel Holland <samuel@sholland.org> > > --- > > .../dts/allwinner/sun50i-h5-orangepi-pc2.dts | 20 +++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > Having a changelog would be great > > > diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts > > index 70b5f09984218..7b2572dc84857 100644 > > --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts > > +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts > > @@ -93,6 +93,10 @@ &codec { > > status = "okay"; > > }; > > > > +&cpu0 { > > + cpu-supply = <®_vdd_cpux>; > > +}; > > + > > &de { > > status = "okay"; > > }; > > @@ -168,6 +172,22 @@ &ohci3 { > > status = "okay"; > > }; > > > > +&r_i2c { > > + status = "okay"; > > + > > + reg_vdd_cpux: regulator@65 { > > + compatible = "silergy,sy8106a"; > > + reg = <0x65>; > > + regulator-name = "vdd-cpux"; > > + silergy,fixed-microvolt = <1100000>; > > + regulator-min-microvolt = <1000000>; > > + regulator-max-microvolt = <1400000>; > > + regulator-ramp-delay = <200>; > > + regulator-boot-on; > > + regulator-always-on; > > + }; > > +}; > > + > > Looks like you fixed the issues reported by Samuel though. I've > applied it. Sorry, yes, I just did that. Re-ordering + removing a comment and changing the fixed voltage. Thank you, o. > Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts index 70b5f09984218..7b2572dc84857 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts +++ b/arch/arm64/boot/dts/allwinner/sun50i-h5-orangepi-pc2.dts @@ -93,6 +93,10 @@ &codec { status = "okay"; }; +&cpu0 { + cpu-supply = <®_vdd_cpux>; +}; + &de { status = "okay"; }; @@ -168,6 +172,22 @@ &ohci3 { status = "okay"; }; +&r_i2c { + status = "okay"; + + reg_vdd_cpux: regulator@65 { + compatible = "silergy,sy8106a"; + reg = <0x65>; + regulator-name = "vdd-cpux"; + silergy,fixed-microvolt = <1100000>; + regulator-min-microvolt = <1000000>; + regulator-max-microvolt = <1400000>; + regulator-ramp-delay = <200>; + regulator-boot-on; + regulator-always-on; + }; +}; + &spi0 { status = "okay";