| Message ID | 20200302213402.9650-1-natechancellor@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | coresight: cti: Remove unnecessary NULL check in cti_sig_type_name | expand |
On Mon, Mar 2, 2020 at 1:34 PM Nathan Chancellor <natechancellor@gmail.com> wrote: > > Clang warns: > > drivers/hwtracing/coresight/coresight-cti-sysfs.c:948:11: warning: > address of array 'grp->sig_types' will always evaluate to 'true' > [-Wpointer-bool-conversion] > if (grp->sig_types) { > ~~ ~~~~~^~~~~~~~~ > 1 warning generated. > > sig_types is at the end of a struct so it cannot be NULL. > > Fixes: 85b6684eab65 ("coresight: cti: Add connection information to sysfs") > Link: https://github.com/ClangBuiltLinux/linux/issues/914 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> Yep, GCC and Clang both eliminate the false case as impossible: https://godbolt.org/z/tjbDqR Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> > --- > drivers/hwtracing/coresight/coresight-cti-sysfs.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > index abb7f492c2cb..214d6552b494 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > @@ -945,10 +945,8 @@ cti_sig_type_name(struct cti_trig_con *con, int used_count, bool in) > int idx = 0; > struct cti_trig_grp *grp = in ? con->con_in : con->con_out; > > - if (grp->sig_types) { > - if (used_count < grp->nr_sigs) > - idx = grp->sig_types[used_count]; > - } > + if (used_count < grp->nr_sigs) > + idx = grp->sig_types[used_count]; > return sig_type_names[idx]; > } > > --
On Mon, Mar 2, 2020 at 1:51 PM Nick Desaulniers <ndesaulniers@google.com> wrote: > > On Mon, Mar 2, 2020 at 1:34 PM Nathan Chancellor > <natechancellor@gmail.com> wrote: > > > > Clang warns: > > > > drivers/hwtracing/coresight/coresight-cti-sysfs.c:948:11: warning: > > address of array 'grp->sig_types' will always evaluate to 'true' > > [-Wpointer-bool-conversion] > > if (grp->sig_types) { > > ~~ ~~~~~^~~~~~~~~ > > 1 warning generated. > > > > sig_types is at the end of a struct so it cannot be NULL. > > > > Fixes: 85b6684eab65 ("coresight: cti: Add connection information to sysfs") > > Link: https://github.com/ClangBuiltLinux/linux/issues/914 > > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > > Yep, GCC and Clang both eliminate the false case as impossible: > https://godbolt.org/z/tjbDqR > Reviewed-by: Nick Desaulniers <ndesaulniers@google.com> 0day just reported this, too (3 minutes after you sent your patch) https://groups.google.com/forum/#!msg/clang-built-linux/_SpkRyhMIxI/IrBtEk-8AAAJ If you wanted to show some love for the bot: Reported-by: kbuild test robot <lkp@intel.com> > > > --- > > drivers/hwtracing/coresight/coresight-cti-sysfs.c | 6 ++---- > > 1 file changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > > index abb7f492c2cb..214d6552b494 100644 > > --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c > > +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > > @@ -945,10 +945,8 @@ cti_sig_type_name(struct cti_trig_con *con, int used_count, bool in) > > int idx = 0; > > struct cti_trig_grp *grp = in ? con->con_in : con->con_out; > > > > - if (grp->sig_types) { > > - if (used_count < grp->nr_sigs) > > - idx = grp->sig_types[used_count]; > > - } > > + if (used_count < grp->nr_sigs) > > + idx = grp->sig_types[used_count]; > > return sig_type_names[idx]; > > } > > > > -- > > > -- > Thanks, > ~Nick Desaulniers
On Mon, 2 Mar 2020 at 14:34, Nathan Chancellor <natechancellor@gmail.com> wrote: > > Clang warns: > > drivers/hwtracing/coresight/coresight-cti-sysfs.c:948:11: warning: > address of array 'grp->sig_types' will always evaluate to 'true' > [-Wpointer-bool-conversion] > if (grp->sig_types) { > ~~ ~~~~~^~~~~~~~~ > 1 warning generated. > > sig_types is at the end of a struct so it cannot be NULL. > > Fixes: 85b6684eab65 ("coresight: cti: Add connection information to sysfs") > Link: https://github.com/ClangBuiltLinux/linux/issues/914 > Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> > --- > drivers/hwtracing/coresight/coresight-cti-sysfs.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > index abb7f492c2cb..214d6552b494 100644 > --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c > +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c > @@ -945,10 +945,8 @@ cti_sig_type_name(struct cti_trig_con *con, int used_count, bool in) > int idx = 0; > struct cti_trig_grp *grp = in ? con->con_in : con->con_out; > > - if (grp->sig_types) { > - if (used_count < grp->nr_sigs) > - idx = grp->sig_types[used_count]; > - } > + if (used_count < grp->nr_sigs) > + idx = grp->sig_types[used_count]; > return sig_type_names[idx]; > } Applied - thanks, Mathieu > > -- > 2.25.1 >
diff --git a/drivers/hwtracing/coresight/coresight-cti-sysfs.c b/drivers/hwtracing/coresight/coresight-cti-sysfs.c index abb7f492c2cb..214d6552b494 100644 --- a/drivers/hwtracing/coresight/coresight-cti-sysfs.c +++ b/drivers/hwtracing/coresight/coresight-cti-sysfs.c @@ -945,10 +945,8 @@ cti_sig_type_name(struct cti_trig_con *con, int used_count, bool in) int idx = 0; struct cti_trig_grp *grp = in ? con->con_in : con->con_out; - if (grp->sig_types) { - if (used_count < grp->nr_sigs) - idx = grp->sig_types[used_count]; - } + if (used_count < grp->nr_sigs) + idx = grp->sig_types[used_count]; return sig_type_names[idx]; }
Clang warns: drivers/hwtracing/coresight/coresight-cti-sysfs.c:948:11: warning: address of array 'grp->sig_types' will always evaluate to 'true' [-Wpointer-bool-conversion] if (grp->sig_types) { ~~ ~~~~~^~~~~~~~~ 1 warning generated. sig_types is at the end of a struct so it cannot be NULL. Fixes: 85b6684eab65 ("coresight: cti: Add connection information to sysfs") Link: https://github.com/ClangBuiltLinux/linux/issues/914 Signed-off-by: Nathan Chancellor <natechancellor@gmail.com> --- drivers/hwtracing/coresight/coresight-cti-sysfs.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)