| Message ID | 20200305122259.6104-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 442a46ad103ed38ddaaba1d9f7d316beb492c66e |
| Headers | show |
| Series | ethernet:broadcom:bcm63xx_enet:remove redundant variable definitions | expand |
On 3/5/20 4:22 AM, tangbin wrote: > in this function,‘ret’ is always assigned,so this's definition > 'ret = 0' make no sense. > > Signed-off-by: tangbin <tangbin@cmss.chinamobile.com> This looks fine, but your subject should be: bcm63xx_enet: Remove redundant variable definitions to matchthe majority of commit subjects done to that file. With that: Acked-by: Florian Fainelli <f.fainelli@gmail.com>
From: tangbin <tangbin@cmss.chinamobile.com> Date: Thu, 5 Mar 2020 20:22:59 +0800 > in this function,‘ret’ is always assigned,so this's definition > 'ret = 0' make no sense. > > Signed-off-by: tangbin <tangbin@cmss.chinamobile.com> Applied with Subject line fixed.
diff --git a/drivers/net/ethernet/broadcom/bcm63xx_enet.c b/drivers/net/ethernet/broadcom/bcm63xx_enet.c index 620cd3fc1..ea5087a8e 100644 --- a/drivers/net/ethernet/broadcom/bcm63xx_enet.c +++ b/drivers/net/ethernet/broadcom/bcm63xx_enet.c @@ -1706,7 +1706,6 @@ static int bcm_enet_probe(struct platform_device *pdev) if (!res_irq || !res_irq_rx || !res_irq_tx) return -ENODEV; - ret = 0; dev = alloc_etherdev(sizeof(*priv)); if (!dev) return -ENOMEM;
in this function,‘ret’ is always assigned,so this's definition 'ret = 0' make no sense. Signed-off-by: tangbin <tangbin@cmss.chinamobile.com> --- drivers/net/ethernet/broadcom/bcm63xx_enet.c | 1 - 1 file changed, 1 deletion(-)