| Message ID | 20200313053224.8172-3-o.rempel@pengutronix.de (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | properly define some of PHYs | expand |
On Fri, Mar 13, 2020 at 06:32:24AM +0100, Oleksij Rempel wrote: > The Atheros AR8035 PHY can be autodetected but can't use interrupt > support provided on this board. Define MDIO bus and the PHY node to make > it work properly. > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > --- > arch/arm/boot/dts/imx6q-marsboard.dts | 15 ++++++++++++++- > 1 file changed, 14 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts > index 84b30bd6908f..1f31d86a217b 100644 > --- a/arch/arm/boot/dts/imx6q-marsboard.dts > +++ b/arch/arm/boot/dts/imx6q-marsboard.dts > @@ -111,8 +111,21 @@ &fec { > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_enet>; > phy-mode = "rgmii-id"; > - phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>; > status = "okay"; Hi Oleksij I don't see a phy-handle here. So is it still using phy_find_first()? Andrew
On Fri, Mar 13, 2020 at 10:55:45AM +0100, Andrew Lunn wrote: > On Fri, Mar 13, 2020 at 06:32:24AM +0100, Oleksij Rempel wrote: > > The Atheros AR8035 PHY can be autodetected but can't use interrupt > > support provided on this board. Define MDIO bus and the PHY node to make > > it work properly. > > > > Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> > > --- > > arch/arm/boot/dts/imx6q-marsboard.dts | 15 ++++++++++++++- > > 1 file changed, 14 insertions(+), 1 deletion(-) > > > > diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts > > index 84b30bd6908f..1f31d86a217b 100644 > > --- a/arch/arm/boot/dts/imx6q-marsboard.dts > > +++ b/arch/arm/boot/dts/imx6q-marsboard.dts > > @@ -111,8 +111,21 @@ &fec { > > pinctrl-names = "default"; > > pinctrl-0 = <&pinctrl_enet>; > > phy-mode = "rgmii-id"; > > - phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>; > > status = "okay"; > > Hi Oleksij > > I don't see a phy-handle here. So is it still using phy_find_first()? Uff... right. Thx for pointing it. Regards, Oleksij
diff --git a/arch/arm/boot/dts/imx6q-marsboard.dts b/arch/arm/boot/dts/imx6q-marsboard.dts index 84b30bd6908f..1f31d86a217b 100644 --- a/arch/arm/boot/dts/imx6q-marsboard.dts +++ b/arch/arm/boot/dts/imx6q-marsboard.dts @@ -111,8 +111,21 @@ &fec { pinctrl-names = "default"; pinctrl-0 = <&pinctrl_enet>; phy-mode = "rgmii-id"; - phy-reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>; status = "okay"; + + mdio { + #address-cells = <1>; + #size-cells = <0>; + + /* Atheros AR8035 PHY */ + rgmii_phy: ethernet-phy@4 { + reg = <4>; + interrupts-extended = <&gpio1 28 IRQ_TYPE_LEVEL_LOW>; + reset-gpios = <&gpio3 31 GPIO_ACTIVE_LOW>; + reset-assert-us = <10000>; + reset-deassert-us = <1000>; + }; + }; }; &hdmi {
The Atheros AR8035 PHY can be autodetected but can't use interrupt support provided on this board. Define MDIO bus and the PHY node to make it work properly. Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de> --- arch/arm/boot/dts/imx6q-marsboard.dts | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-)