From patchwork Thu Mar 19 23:11:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chen Huang X-Patchwork-Id: 11448223 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 80A9713B1 for ; Fri, 20 Mar 2020 01:29:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 57BAC20752 for ; Fri, 20 Mar 2020 01:29:10 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="rwcdczFz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 57BAC20752 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=+AfvtIev0d+m5Er5iAP3im6oDidh35apLucGGZiWInA=; b=rwcdczFz78Cr9P p3Rnj9P+wdRw0AwdY7oocy+/1KT2KQ3nCWIrsIXYTvARTqoPftVS9hjzPNXUZ4kGIWfWnKdyjq/et +p9vxilJmUTLT/qPL4qNV90a3kKM+QHIFqCoKK9uGi42JAljMm+yNfyjU9rqY5VoJV2AWPpYFy7+m srhlcyM+vTVYR6f9ZoY0XxGqEHfuJZs7zaXVbPKk8SWjtn5dJkTPMHeJcO3lwT6wsox4AFn9jiXyt /TAQfor2HlidTi0EhiNYtbYtwtz5YUtbwakgvPqbAVO1XLaelAEnTV1XjF2qlib3ZGqGjxetVGqy7 ttll1nws1xfaN+aqRa3Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jF6TE-0003Ga-Lw; Fri, 20 Mar 2020 01:29:08 +0000 Received: from szxga04-in.huawei.com ([45.249.212.190] helo=huawei.com) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jF6TB-00034y-PX for linux-arm-kernel@lists.infradead.org; Fri, 20 Mar 2020 01:29:07 +0000 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 8FDBE9DD9CCE3F553607; Fri, 20 Mar 2020 09:28:51 +0800 (CST) Received: from ubuntu.huawei.com (10.175.104.215) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Fri, 20 Mar 2020 09:28:41 +0800 From: Chen Huang To: Santosh Shilimkar Subject: [PATCH -next] soc: ti: pm33xx: Add a judgement for variable 'ret' Date: Fri, 20 Mar 2020 07:11:50 +0800 Message-ID: <20200319231150.28106-1-chenhuang5@huawei.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 X-Originating-IP: [10.175.104.215] X-CFilter-Loop: Reflected X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200319_182905_995163_C3196116 X-CRM114-Status: UNSURE ( 8.55 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -2.3 (--) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [45.249.212.190 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Dave Gerlach , Chen Huang , linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org Variable 'ret' is the result whether sram has prepared to translate to low power state. 0 represents preparation is successful, others represent error code. If preparation failed, then return 'ret' to end the function. Fixes gcc '-Wunused-but-set-variable' warning: drivers/soc/ti/pm33xx.c: In function am33xx_do_sram_idle: drivers/soc/ti/pm33xx.c:135:6: warning: variable ret set but not used [-Wunused-but-set-variable] Fixes: commit 6afaff1c6624f ("soc: ti: pm33xx: Add base cpuidle support") Reported-by: Hulk Robot Signed-off-by: Chen Huang --- drivers/soc/ti/pm33xx.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soc/ti/pm33xx.c b/drivers/soc/ti/pm33xx.c index de0123ec8ad6..a51ba770f1e3 100644 --- a/drivers/soc/ti/pm33xx.c +++ b/drivers/soc/ti/pm33xx.c @@ -139,6 +139,8 @@ static int am33xx_do_sram_idle(u32 wfi_flags) if (wfi_flags & WFI_FLAG_WAKE_M3) ret = m3_ipc->ops->prepare_low_power(m3_ipc, WKUP_M3_IDLE); + if (ret) + return ret; return pm_ops->cpu_suspend(am33xx_do_wfi_sram, wfi_flags); }