| Message ID | 20200320035104.26139-4-matheus@castello.eng.br (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add Caninos Loucos Labrador CoM and Base Board Device Tree | expand |
On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote: > Add Device Trees for Caninos Loucos Labrador CoM and base board. > Based on the work of Andreas Färber on Lemaker Guitar device tree. > > Signed-off-by: Matheus Castello <matheus@castello.eng.br> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Will queue the series for v5.8 once Andreas is happy with it. Nit: Please keep linux-actions@lists.infradead.org in CC for all future patches/replies. Thanks, Mani > --- > arch/arm/boot/dts/Makefile | 1 + > arch/arm/boot/dts/owl-s500-labrador-bb.dts | 34 +++++++++++++++++++++ > arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++ > 3 files changed, 56 insertions(+) > create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts > create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi > > diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile > index d6546d2676b9..99f633460833 100644 > --- a/arch/arm/boot/dts/Makefile > +++ b/arch/arm/boot/dts/Makefile > @@ -842,6 +842,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \ > dtb-$(CONFIG_ARCH_ACTIONS) += \ > owl-s500-cubieboard6.dtb \ > owl-s500-guitar-bb-rev-b.dtb \ > + owl-s500-labrador-bb.dtb \ > owl-s500-sparky.dtb > dtb-$(CONFIG_ARCH_PRIMA2) += \ > prima2-evb.dtb > diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts > new file mode 100644 > index 000000000000..91012b4a4c30 > --- /dev/null > +++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts > @@ -0,0 +1,34 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Caninos Labrador Base Board > + * > + * Copyright (c) 2019-2020 Matheus Castello > + */ > + > +/dts-v1/; > + > +#include "owl-s500-labrador-v2.dtsi" > + > +/ { > + compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500"; > + model = "Caninos Labrador Base Board M v1.0"; > + > + aliases { > + serial3 = &uart3; > + }; > + > + chosen { > + stdout-path = "serial3:115200n8"; > + }; > + > + uart3_clk: uart3-clk { > + compatible = "fixed-clock"; > + clock-frequency = <921600>; > + #clock-cells = <0>; > + }; > +}; > + > +&uart3 { > + status = "okay"; > + clocks = <&uart3_clk>; > +}; > diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi > new file mode 100644 > index 000000000000..0b54f1ef3ec0 > --- /dev/null > +++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > +/* > + * Caninos Labrador CoM V2 > + * > + * Copyright (c) 2019-2020 Matheus Castello > + */ > + > +#include "owl-s500.dtsi" > + > +/ { > + compatible = "caninos,labrador", "actions,s500"; > + > + memory@0 { > + device_type = "memory"; > + reg = <0x0 0x80000000>; > + }; > +}; > + > +&timer { > + clocks = <&hosc>; > +}; > -- > 2.25.0 >
Hi Andreas, Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu: > On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote: >> Add Device Trees for Caninos Loucos Labrador CoM and base board. >> Based on the work of Andreas Färber on Lemaker Guitar device tree. >> >> Signed-off-by: Matheus Castello <matheus@castello.eng.br> > > Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > > Will queue the series for v5.8 once Andreas is happy with it. > do you have any more concerns about these patches? Let me know. BR, Matheus Castello > Nit: Please keep linux-actions@lists.infradead.org in CC for all future > patches/replies. > > Thanks, > Mani > >> --- >> arch/arm/boot/dts/Makefile | 1 + >> arch/arm/boot/dts/owl-s500-labrador-bb.dts | 34 +++++++++++++++++++++ >> arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++ >> 3 files changed, 56 insertions(+) >> create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts >> create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi >> >> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile >> index d6546d2676b9..99f633460833 100644 >> --- a/arch/arm/boot/dts/Makefile >> +++ b/arch/arm/boot/dts/Makefile >> @@ -842,6 +842,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \ >> dtb-$(CONFIG_ARCH_ACTIONS) += \ >> owl-s500-cubieboard6.dtb \ >> owl-s500-guitar-bb-rev-b.dtb \ >> + owl-s500-labrador-bb.dtb \ >> owl-s500-sparky.dtb >> dtb-$(CONFIG_ARCH_PRIMA2) += \ >> prima2-evb.dtb >> diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts >> new file mode 100644 >> index 000000000000..91012b4a4c30 >> --- /dev/null >> +++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts >> @@ -0,0 +1,34 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * Caninos Labrador Base Board >> + * >> + * Copyright (c) 2019-2020 Matheus Castello >> + */ >> + >> +/dts-v1/; >> + >> +#include "owl-s500-labrador-v2.dtsi" >> + >> +/ { >> + compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500"; >> + model = "Caninos Labrador Base Board M v1.0"; >> + >> + aliases { >> + serial3 = &uart3; >> + }; >> + >> + chosen { >> + stdout-path = "serial3:115200n8"; >> + }; >> + >> + uart3_clk: uart3-clk { >> + compatible = "fixed-clock"; >> + clock-frequency = <921600>; >> + #clock-cells = <0>; >> + }; >> +}; >> + >> +&uart3 { >> + status = "okay"; >> + clocks = <&uart3_clk>; >> +}; >> diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi >> new file mode 100644 >> index 000000000000..0b54f1ef3ec0 >> --- /dev/null >> +++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi >> @@ -0,0 +1,21 @@ >> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) >> +/* >> + * Caninos Labrador CoM V2 >> + * >> + * Copyright (c) 2019-2020 Matheus Castello >> + */ >> + >> +#include "owl-s500.dtsi" >> + >> +/ { >> + compatible = "caninos,labrador", "actions,s500"; >> + >> + memory@0 { >> + device_type = "memory"; >> + reg = <0x0 0x80000000>; >> + }; >> +}; >> + >> +&timer { >> + clocks = <&hosc>; >> +}; >> -- >> 2.25.0 >>
Hi Matheus, Am 23.04.20 um 17:20 schrieb Matheus Castello: > Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu: >> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote: >>> Add Device Trees for Caninos Loucos Labrador CoM and base board. >>> Based on the work of Andreas Färber on Lemaker Guitar device tree. >>> >>> Signed-off-by: Matheus Castello <matheus@castello.eng.br> >> >> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >> >> Will queue the series for v5.8 once Andreas is happy with it. > > do you have any more concerns about these patches? Let me know. I've reviewed the preceding two patches. This one here looks okay, Reviewed-by: Andreas Färber <afaerber@suse.de> but see 2/3 - model here does contain M and your .dtsi is named -v2 - what's the difference to v1? If it's big enough to warrant a separate .dtsi, you should consider whether a versioned compatible string may be needed, too (likely in addition to, not instead of a generic one). No v1 info on the website. Thanks, Andreas
Hi Andreas, thanks for the review. Em 4/26/20 8:58 AM, Andreas Färber escreveu: > Hi Matheus, > > Am 23.04.20 um 17:20 schrieb Matheus Castello: >> Em 4/5/20 3:51 AM, Manivannan Sadhasivam escreveu: >>> On Fri, Mar 20, 2020 at 12:51:04AM -0300, Matheus Castello wrote: >>>> Add Device Trees for Caninos Loucos Labrador CoM and base board. >>>> Based on the work of Andreas Färber on Lemaker Guitar device tree. >>>> >>>> Signed-off-by: Matheus Castello <matheus@castello.eng.br> >>> >>> Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> >>> >>> Will queue the series for v5.8 once Andreas is happy with it. >> >> do you have any more concerns about these patches? Let me know. > > I've reviewed the preceding two patches. This one here looks okay, > > Reviewed-by: Andreas Färber <afaerber@suse.de> > > but see 2/3 - model here does contain M and your .dtsi is named -v2 - > what's the difference to v1? If it's big enough to warrant a separate > .dtsi, you should consider whether a versioned compatible string may be > needed, too (likely in addition to, not instead of a generic one). No v1 > info on the website. > The difference between v1 and v2 is the model and vendor of the DRAM and storage eMMC. But that had no impact on the software. Checking examples on "/Documentation/devicetree/bindings/arm/" I saw that some add enum descriptions for both the base board and system on module, keeping in const only the vendor prefix of the SoC. And in the device tree both have the model property description. I liked this example, I think I will follow it in v4. About "-bb-" in the file name and description: on PCB is written "Labrador Base-M v1.0a", so with that I think it is better to leave only base on the name. I will send the v4, thank you very much for the review. BR, Matheus Castello > Thanks, > Andreas >
diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile index d6546d2676b9..99f633460833 100644 --- a/arch/arm/boot/dts/Makefile +++ b/arch/arm/boot/dts/Makefile @@ -842,6 +842,7 @@ dtb-$(CONFIG_ARCH_ORION5X) += \ dtb-$(CONFIG_ARCH_ACTIONS) += \ owl-s500-cubieboard6.dtb \ owl-s500-guitar-bb-rev-b.dtb \ + owl-s500-labrador-bb.dtb \ owl-s500-sparky.dtb dtb-$(CONFIG_ARCH_PRIMA2) += \ prima2-evb.dtb diff --git a/arch/arm/boot/dts/owl-s500-labrador-bb.dts b/arch/arm/boot/dts/owl-s500-labrador-bb.dts new file mode 100644 index 000000000000..91012b4a4c30 --- /dev/null +++ b/arch/arm/boot/dts/owl-s500-labrador-bb.dts @@ -0,0 +1,34 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Caninos Labrador Base Board + * + * Copyright (c) 2019-2020 Matheus Castello + */ + +/dts-v1/; + +#include "owl-s500-labrador-v2.dtsi" + +/ { + compatible = "caninos,labrador-bb", "caninos,labrador", "actions,s500"; + model = "Caninos Labrador Base Board M v1.0"; + + aliases { + serial3 = &uart3; + }; + + chosen { + stdout-path = "serial3:115200n8"; + }; + + uart3_clk: uart3-clk { + compatible = "fixed-clock"; + clock-frequency = <921600>; + #clock-cells = <0>; + }; +}; + +&uart3 { + status = "okay"; + clocks = <&uart3_clk>; +}; diff --git a/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi new file mode 100644 index 000000000000..0b54f1ef3ec0 --- /dev/null +++ b/arch/arm/boot/dts/owl-s500-labrador-v2.dtsi @@ -0,0 +1,21 @@ +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) +/* + * Caninos Labrador CoM V2 + * + * Copyright (c) 2019-2020 Matheus Castello + */ + +#include "owl-s500.dtsi" + +/ { + compatible = "caninos,labrador", "actions,s500"; + + memory@0 { + device_type = "memory"; + reg = <0x0 0x80000000>; + }; +}; + +&timer { + clocks = <&hosc>; +};
Add Device Trees for Caninos Loucos Labrador CoM and base board. Based on the work of Andreas Färber on Lemaker Guitar device tree. Signed-off-by: Matheus Castello <matheus@castello.eng.br> --- arch/arm/boot/dts/Makefile | 1 + arch/arm/boot/dts/owl-s500-labrador-bb.dts | 34 +++++++++++++++++++++ arch/arm/boot/dts/owl-s500-labrador-v2.dtsi | 21 +++++++++++++ 3 files changed, 56 insertions(+) create mode 100644 arch/arm/boot/dts/owl-s500-labrador-bb.dts create mode 100644 arch/arm/boot/dts/owl-s500-labrador-v2.dtsi -- 2.25.0