| Message ID | 20200326182742.487026-1-enric.balletbo@collabora.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | soc: mediatek: mtk-mmsys: Export ddp_dis/connect symbols | expand |
On Thu, 26 Mar 2020 at 19:27, Enric Balletbo i Serra <enric.balletbo@collabora.com> wrote: > > When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see > the following error. > > ERROR: modpost: "mtk_mmsys_ddp_disconnect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > ERROR: modpost: "mtk_mmsys_ddp_connect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > > Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be > able to be used for other modules. > > Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device") > Reported-by: Anders Roxell <anders.roxell@linaro.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Tested-by: Anders Roxell <anders.roxell@linaro.org> Cheers, Anders > --- > > drivers/soc/mediatek/mtk-mmsys.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c > index 32a92ec447c5..05e322c9c301 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect); > > void mtk_mmsys_ddp_disconnect(struct device *dev, > enum mtk_ddp_comp_id cur, > @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect); > > static int mtk_mmsys_probe(struct platform_device *pdev) > { > -- > 2.25.1 >
Hi, Enric: Enric Balletbo i Serra <enric.balletbo@collabora.com> 於 2020年3月27日 週五 上午2:28寫道： > > When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see > the following error. > > ERROR: modpost: "mtk_mmsys_ddp_disconnect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > ERROR: modpost: "mtk_mmsys_ddp_connect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > > Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be > able to be used for other modules. > Reviewed-by: Chun-Kuang Hu <chunkuang.hu@kernel.org> > Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device") > Reported-by: Anders Roxell <anders.roxell@linaro.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> > --- > > drivers/soc/mediatek/mtk-mmsys.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c > index 32a92ec447c5..05e322c9c301 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect); > > void mtk_mmsys_ddp_disconnect(struct device *dev, > enum mtk_ddp_comp_id cur, > @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect); > > static int mtk_mmsys_probe(struct platform_device *pdev) > { > -- > 2.25.1 > > > _______________________________________________ > Linux-mediatek mailing list > Linux-mediatek@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-mediatek
On 26/03/2020 19:27, Enric Balletbo i Serra wrote: > When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see > the following error. > > ERROR: modpost: "mtk_mmsys_ddp_disconnect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > ERROR: modpost: "mtk_mmsys_ddp_connect" > [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! > > Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be > able to be used for other modules. > > Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device") > Reported-by: Anders Roxell <anders.roxell@linaro.org> > Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> I squashed this into the old commit: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device") And pushed it out to v5.6-next/soc Thanks! > --- > > drivers/soc/mediatek/mtk-mmsys.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c > index 32a92ec447c5..05e322c9c301 100644 > --- a/drivers/soc/mediatek/mtk-mmsys.c > +++ b/drivers/soc/mediatek/mtk-mmsys.c > @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect); > > void mtk_mmsys_ddp_disconnect(struct device *dev, > enum mtk_ddp_comp_id cur, > @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev, > writel_relaxed(reg, config_regs + addr); > } > } > +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect); > > static int mtk_mmsys_probe(struct platform_device *pdev) > { >
diff --git a/drivers/soc/mediatek/mtk-mmsys.c b/drivers/soc/mediatek/mtk-mmsys.c index 32a92ec447c5..05e322c9c301 100644 --- a/drivers/soc/mediatek/mtk-mmsys.c +++ b/drivers/soc/mediatek/mtk-mmsys.c @@ -259,6 +259,7 @@ void mtk_mmsys_ddp_connect(struct device *dev, writel_relaxed(reg, config_regs + addr); } } +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_connect); void mtk_mmsys_ddp_disconnect(struct device *dev, enum mtk_ddp_comp_id cur, @@ -279,6 +280,7 @@ void mtk_mmsys_ddp_disconnect(struct device *dev, writel_relaxed(reg, config_regs + addr); } } +EXPORT_SYMBOL_GPL(mtk_mmsys_ddp_disconnect); static int mtk_mmsys_probe(struct platform_device *pdev) {
When building on arm64 with allmodconfig or CONFIG_DRM_MEDIATEK=m we see the following error. ERROR: modpost: "mtk_mmsys_ddp_disconnect" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! ERROR: modpost: "mtk_mmsys_ddp_connect" [drivers/gpu/drm/mediatek/mediatek-drm.ko] undefined! Export mtk_mmsys_ddp_connect and mtk_mmsys_ddp_disconnect symbols to be able to be used for other modules. Fixes: 396c3fccaf03 ("soc / drm: mediatek: Move routing control to mmsys device") Reported-by: Anders Roxell <anders.roxell@linaro.org> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> --- drivers/soc/mediatek/mtk-mmsys.c | 2 ++ 1 file changed, 2 insertions(+)