| Message ID | 20200327163654.13389-3-sudeep.holla@arm.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b9d15ee21cd8cf088ac574649ae7ac2fefaa440a |
| Headers | show |
| Series | firmware: arm_scmi: Extend SMC/HVC to support multiple channels | expand |
> Subject: [PATCH 2/4] firmware: arm_scmi: Drop empty stub for > smc_mark_txdone > > The scmi protocol core driver check for non NULL mark_txdone before > invoking the same. There is no need to provide a empty stub. SMC/HVC calls > are synchronous and the call return indicates the completion. > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> Reviewed-by: Peng Fan <peng.fan@nxp.com> > --- > drivers/firmware/arm_scmi/smc.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/firmware/arm_scmi/smc.c > b/drivers/firmware/arm_scmi/smc.c index 6dc8a88cc91b..dd4b54c29679 > 100644 > --- a/drivers/firmware/arm_scmi/smc.c > +++ b/drivers/firmware/arm_scmi/smc.c > @@ -114,10 +114,6 @@ static int smc_send_message(struct scmi_chan_info > *cinfo, > return res.a0; > } > > -static void smc_mark_txdone(struct scmi_chan_info *cinfo, int ret) -{ -} > - > static void smc_fetch_response(struct scmi_chan_info *cinfo, > struct scmi_xfer *xfer) > { > @@ -139,7 +135,6 @@ static struct scmi_transport_ops scmi_smc_ops = { > .chan_setup = smc_chan_setup, > .chan_free = smc_chan_free, > .send_message = smc_send_message, > - .mark_txdone = smc_mark_txdone, > .fetch_response = smc_fetch_response, > .poll_done = smc_poll_done, > }; > -- > 2.17.1
diff --git a/drivers/firmware/arm_scmi/smc.c b/drivers/firmware/arm_scmi/smc.c index 6dc8a88cc91b..dd4b54c29679 100644 --- a/drivers/firmware/arm_scmi/smc.c +++ b/drivers/firmware/arm_scmi/smc.c @@ -114,10 +114,6 @@ static int smc_send_message(struct scmi_chan_info *cinfo, return res.a0; } -static void smc_mark_txdone(struct scmi_chan_info *cinfo, int ret) -{ -} - static void smc_fetch_response(struct scmi_chan_info *cinfo, struct scmi_xfer *xfer) { @@ -139,7 +135,6 @@ static struct scmi_transport_ops scmi_smc_ops = { .chan_setup = smc_chan_setup, .chan_free = smc_chan_free, .send_message = smc_send_message, - .mark_txdone = smc_mark_txdone, .fetch_response = smc_fetch_response, .poll_done = smc_poll_done, };
The scmi protocol core driver check for non NULL mark_txdone before invoking the same. There is no need to provide a empty stub. SMC/HVC calls are synchronous and the call return indicates the completion. Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/firmware/arm_scmi/smc.c | 5 ----- 1 file changed, 5 deletions(-)