| Message ID | 20200402115940.4928-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 5810f00ade49f4710a9e834db5a3ad786a76e880 |
| Headers | show |
| Series | perf:Avoid duplicate printouts | expand |
On Thu, 2 Apr 2020 19:59:40 +0800, Tang Bin wrote: > Because platform_get_irq() has dev_err(),so this place > should be removed. Applied to arm64 (for-next/perf), thanks! [1/1] drivers/perf: arm_dsu_pmu: Avoid duplicate printouts https://git.kernel.org/arm64/c/5810f00ade49 Cheers,
diff --git a/drivers/perf/arm_dsu_pmu.c b/drivers/perf/arm_dsu_pmu.c index 70968c8c0..518d0603e 100644 --- a/drivers/perf/arm_dsu_pmu.c +++ b/drivers/perf/arm_dsu_pmu.c @@ -690,10 +690,8 @@ static int dsu_pmu_device_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_warn(&pdev->dev, "Failed to find IRQ\n"); + if (irq < 0) return -EINVAL; - } name = devm_kasprintf(&pdev->dev, GFP_KERNEL, "%s_%d", PMUNAME, atomic_inc_return(&pmu_idx));
Because platform_get_irq() has dev_err(),so this place should be removed. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/perf/arm_dsu_pmu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)