| Message ID | 20200402120330.19468-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 1f0d97bb7082ead69acc899cd5dae9deb8b91577 |
| Headers | show |
| Series | perf:arm_spe:Avoid duplicate printouts | expand |
On Thu, 2 Apr 2020 20:03:30 +0800, Tang Bin wrote: > Because platform_get_irq() has dev_err(),so this place > should be removed. Applied to arm64 (for-next/perf), thanks! [1/1] drivers/perf: arm_spe_pmu: Avoid duplicate printouts https://git.kernel.org/arm64/c/1f0d97bb7082 Cheers,
diff --git a/drivers/perf/arm_spe_pmu.c b/drivers/perf/arm_spe_pmu.c index 4e4984a55..dd561880d 100644 --- a/drivers/perf/arm_spe_pmu.c +++ b/drivers/perf/arm_spe_pmu.c @@ -1133,10 +1133,8 @@ static int arm_spe_pmu_irq_probe(struct arm_spe_pmu *spe_pmu) struct platform_device *pdev = spe_pmu->pdev; int irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(&pdev->dev, "failed to get IRQ (%d)\n", irq); + if (irq < 0) return -ENXIO; - } if (!irq_is_percpu(irq)) { dev_err(&pdev->dev, "expected PPI but got SPI (%d)\n", irq);
Because platform_get_irq() has dev_err(),so this place should be removed. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/perf/arm_spe_pmu.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)