| Message ID | 20200403082423.8800-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [v2] ARM:zx:Delete duplicate dev_err message in zx296702_pd_probe() | expand |
diff --git a/arch/arm/mach-zx/zx296702-pm-domain.c b/arch/arm/mach-zx/zx296702-pm-domain.c index 7a08bf9dd..ac44ea8e6 100644 --- a/arch/arm/mach-zx/zx296702-pm-domain.c +++ b/arch/arm/mach-zx/zx296702-pm-domain.c @@ -169,10 +169,8 @@ static int zx296702_pd_probe(struct platform_device *pdev) } pcubase = devm_ioremap_resource(&pdev->dev, res); - if (IS_ERR(pcubase)) { - dev_err(&pdev->dev, "ioremap fail.\n"); + if (IS_ERR(pcubase)) return -EIO; - } for (i = 0; i < ARRAY_SIZE(zx296702_pm_domains); ++i) pm_genpd_init(zx296702_pm_domains[i], NULL, false);
In this place,devm_ioremap_resource() has already contains error message, so delete the duplicate dev_err message. Changes from v1: - the title has changed, because the description is not very detailed and the formate is wrong. So I find an other wording more appropriate. As suggested by Markus Elfring: This is another attempt for the previous update suggestion, v1 can be found here: https://lore.kernel.org/patchwork/patch/1203764/ Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- arch/arm/mach-zx/zx296702-pm-domain.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)