| Message ID | 20200406053450.8380-1-tangbin@cmss.chinamobile.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 7606662686154d28d53b5acd41fc8678aefaec71 |
| Headers | show |
| Series | video: fbdev: don't print error message on platform_get_irq() failure | expand |
On 06/04/2020 at 07:34, Tang Bin wrote: > The platform_get_irq() can print error message,so remove the redundant > dev_err() here. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> > --- > drivers/video/fbdev/atmel_lcdfb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c > index d567f5d56..1e2521925 100644 > --- a/drivers/video/fbdev/atmel_lcdfb.c > +++ b/drivers/video/fbdev/atmel_lcdfb.c > @@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev) > > sinfo->irq_base = platform_get_irq(pdev, 0); > if (sinfo->irq_base < 0) { > - dev_err(dev, "unable to get irq\n"); > ret = sinfo->irq_base; > goto stop_clk; > } > -- > 2.20.1.windows.1 > > >
Hi Tang Bin On Mon, Apr 06, 2020 at 01:34:50PM +0800, Tang Bin wrote: > The platform_get_irq() can print error message,so remove the redundant > dev_err() here. > > Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> > --- > drivers/video/fbdev/atmel_lcdfb.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c > index d567f5d56..1e2521925 100644 > --- a/drivers/video/fbdev/atmel_lcdfb.c > +++ b/drivers/video/fbdev/atmel_lcdfb.c > @@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev) > > sinfo->irq_base = platform_get_irq(pdev, 0); > if (sinfo->irq_base < 0) { > - dev_err(dev, "unable to get irq\n"); > ret = sinfo->irq_base; > goto stop_clk; > } Thanks, applied to drm-misc-next. The fix will appear in kernel 5.8 Sam
diff --git a/drivers/video/fbdev/atmel_lcdfb.c b/drivers/video/fbdev/atmel_lcdfb.c index d567f5d56..1e2521925 100644 --- a/drivers/video/fbdev/atmel_lcdfb.c +++ b/drivers/video/fbdev/atmel_lcdfb.c @@ -1114,7 +1114,6 @@ static int __init atmel_lcdfb_probe(struct platform_device *pdev) sinfo->irq_base = platform_get_irq(pdev, 0); if (sinfo->irq_base < 0) { - dev_err(dev, "unable to get irq\n"); ret = sinfo->irq_base; goto stop_clk; }
The platform_get_irq() can print error message,so remove the redundant dev_err() here. Signed-off-by: Tang Bin <tangbin@cmss.chinamobile.com> --- drivers/video/fbdev/atmel_lcdfb.c | 1 - 1 file changed, 1 deletion(-)