| Message ID | 20200420103113.577969-1-megous@megous.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | cff1110178873d9dfac0e0e848c282954c4b3c63 |
| Headers | show |
| Series | arm64: dts: allwinner: sun50i-a64: Add missing address/size-cells | expand |
On Mon, Apr 20, 2020 at 12:31:13PM +0200, Ondrej Jirman wrote: > The binding specifies #address-cells and #size-cells should be present. > Without them present, dtc issues a warning because default for > #address-cells seems to be <2>: > > arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi:1108.4-52: > Warning (dma_ranges_format): > /soc/dram-controller@1c62000:dma-ranges: > "dma-ranges" property has invalid length (12 bytes) > (parent #address-cells == 1, child #address-cells == 2, > #size-cells == 1) > > mbus #address-cells should be 1. > > Signed-off-by: Ondrej Jirman <megous@megous.com> Applied, thanks Maxime
diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi index cca4261089aa..61698094f450 100644 --- a/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi +++ b/arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi @@ -1105,6 +1105,8 @@ mbus: dram-controller@1c62000 { compatible = "allwinner,sun50i-a64-mbus"; reg = <0x01c62000 0x1000>; clocks = <&ccu 112>; + #address-cells = <1>; + #size-cells = <1>; dma-ranges = <0x00000000 0x40000000 0xc0000000>; #interconnect-cells = <1>; };
The binding specifies #address-cells and #size-cells should be present. Without them present, dtc issues a warning because default for #address-cells seems to be <2>: arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi:1108.4-52: Warning (dma_ranges_format): /soc/dram-controller@1c62000:dma-ranges: "dma-ranges" property has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1) mbus #address-cells should be 1. Signed-off-by: Ondrej Jirman <megous@megous.com> --- arch/arm64/boot/dts/allwinner/sun50i-a64.dtsi | 2 ++ 1 file changed, 2 insertions(+)