| Message ID | 20200421032304.26300-2-jianyong.wu@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Enable ptp_kvm for arm64 | expand |
On Tue, Apr 21, 2020 at 11:22:56AM +0800, Jianyong Wu wrote: > Export arm_smccc_1_1_get_conduit then modules can use smccc helper which > adopts it. > > Signed-off-by: Jianyong Wu <jianyong.wu@arm.com> Nit: please say 'smccc conduit' in the commit title. Otherwise, I see not problem with this provided an in-tree module uses this, so: Acked-by: Mark Rutland <mark.rutland@arm.com> Mark. > --- > drivers/firmware/psci/psci.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c > index 2937d44b5df4..fd3c88f21b6a 100644 > --- a/drivers/firmware/psci/psci.c > +++ b/drivers/firmware/psci/psci.c > @@ -64,6 +64,7 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void) > > return psci_ops.conduit; > } > +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit); > > typedef unsigned long (psci_fn)(unsigned long, unsigned long, > unsigned long, unsigned long); > -- > 2.17.1 >
Hi Mark,
On 2020/4/21, 5:41 PM, "Mark Rutland" <mark.rutland@arm.com> wrote:
On Tue, Apr 21, 2020 at 11:22:56AM +0800, Jianyong Wu wrote:
> Export arm_smccc_1_1_get_conduit then modules can use smccc helper which
> adopts it.
>
> Signed-off-by: Jianyong Wu <jianyong.wu@arm.com>
Nit: please say 'smccc conduit' in the commit title.
Ok, I will fix it next version.
Otherwise, I see not problem with this provided an in-tree module uses
this, so:
Acked-by: Mark Rutland <mark.rutland@arm.com>
Thanks! Glad to get this.
Best regards
Jianyong
Mark.
> ---
> drivers/firmware/psci/psci.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c
> index 2937d44b5df4..fd3c88f21b6a 100644
> --- a/drivers/firmware/psci/psci.c
> +++ b/drivers/firmware/psci/psci.c
> @@ -64,6 +64,7 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void)
>
> return psci_ops.conduit;
> }
> +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit);
>
> typedef unsigned long (psci_fn)(unsigned long, unsigned long,
> unsigned long, unsigned long);
> --
> 2.17.1
>
diff --git a/drivers/firmware/psci/psci.c b/drivers/firmware/psci/psci.c index 2937d44b5df4..fd3c88f21b6a 100644 --- a/drivers/firmware/psci/psci.c +++ b/drivers/firmware/psci/psci.c @@ -64,6 +64,7 @@ enum arm_smccc_conduit arm_smccc_1_1_get_conduit(void) return psci_ops.conduit; } +EXPORT_SYMBOL(arm_smccc_1_1_get_conduit); typedef unsigned long (psci_fn)(unsigned long, unsigned long, unsigned long, unsigned long);
Export arm_smccc_1_1_get_conduit then modules can use smccc helper which adopts it. Signed-off-by: Jianyong Wu <jianyong.wu@arm.com> --- drivers/firmware/psci/psci.c | 1 + 1 file changed, 1 insertion(+)