| Message ID | 20200424123923.8192-1-jbx6244@gmail.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 855bdca1781c79eb661f89c8944c4a719ce720e8 |
| Headers | show |
| Series | ARM: dts: rockchip: fix pinctrl sub nodename for spi in rk322x.dtsi | expand |
On Fri, 24 Apr 2020 14:39:23 +0200, Johan Jonker wrote: > A test with the command below gives these errors: > > arch/arm/boot/dts/rk3229-evb.dt.yaml: spi-0: > '#address-cells' is a required property > arch/arm/boot/dts/rk3229-evb.dt.yaml: spi-1: > '#address-cells' is a required property > arch/arm/boot/dts/rk3229-xms6.dt.yaml: spi-0: > '#address-cells' is a required property > arch/arm/boot/dts/rk3229-xms6.dt.yaml: spi-1: > '#address-cells' is a required property > > [...] Applied, thanks! [1/1] ARM: dts: rockchip: fix pinctrl sub nodename for spi in rk322x.dtsi commit: 855bdca1781c79eb661f89c8944c4a719ce720e8 Best regards,
diff --git a/arch/arm/boot/dts/rk322x.dtsi b/arch/arm/boot/dts/rk322x.dtsi index 06172ebbf..e3b27da0a 100644 --- a/arch/arm/boot/dts/rk322x.dtsi +++ b/arch/arm/boot/dts/rk322x.dtsi @@ -1020,7 +1020,7 @@ }; }; - spi-0 { + spi0 { spi0_clk: spi0-clk { rockchip,pins = <0 RK_PB1 2 &pcfg_pull_up>; }; @@ -1038,7 +1038,7 @@ }; }; - spi-1 { + spi1 { spi1_clk: spi1-clk { rockchip,pins = <0 RK_PC7 2 &pcfg_pull_up>; };
A test with the command below gives these errors: arch/arm/boot/dts/rk3229-evb.dt.yaml: spi-0: '#address-cells' is a required property arch/arm/boot/dts/rk3229-evb.dt.yaml: spi-1: '#address-cells' is a required property arch/arm/boot/dts/rk3229-xms6.dt.yaml: spi-0: '#address-cells' is a required property arch/arm/boot/dts/rk3229-xms6.dt.yaml: spi-1: '#address-cells' is a required property The $nodename pattern for spi nodes is "^spi(@.*|-[0-9a-f])*$". To prevent warnings rename 'spi-0' and 'spi-1' pinctrl sub nodenames to 'spi0' and 'spi1' in 'rk322x.dtsi'. make ARCH=arm dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/spi-controller.yaml Signed-off-by: Johan Jonker <jbx6244@gmail.com> --- arch/arm/boot/dts/rk322x.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)