| Message ID | 20200427192932.28967-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | b704fc1da9b84d7145db550a13e2b7140f6b419b |
| Headers | show |
| Series | ARM: dts: r7s9210: Remove bogus clock-names from OSTM nodes | expand |
Hi Geert, On Mon, Apr 27, 2020, Geert Uytterhoeven wrote: > However, the actual clock names for the OS Timer nodes are not fixed, > but contain the indices of the consumer instances. Hence they cannot > easily be used by a driver, without scanning for all possible indices. > > Remove them, as the OSTM DT bindings do not specify clock-names anyway. > --- > To be queued in renesas-fixes for v5.7, to avoid the json-schema OSTM DT > bindings conversion introducing a regression. > --- OK. Thank you. Chris
diff --git a/arch/arm/boot/dts/r7s9210.dtsi b/arch/arm/boot/dts/r7s9210.dtsi index 72b79770e336a79e..cace4380749711d7 100644 --- a/arch/arm/boot/dts/r7s9210.dtsi +++ b/arch/arm/boot/dts/r7s9210.dtsi @@ -304,7 +304,6 @@ reg = <0xe803b000 0x30>; interrupts = <GIC_SPI 56 IRQ_TYPE_EDGE_RISING>; clocks = <&cpg CPG_MOD 36>; - clock-names = "ostm0"; power-domains = <&cpg>; status = "disabled"; }; @@ -314,7 +313,6 @@ reg = <0xe803c000 0x30>; interrupts = <GIC_SPI 57 IRQ_TYPE_EDGE_RISING>; clocks = <&cpg CPG_MOD 35>; - clock-names = "ostm1"; power-domains = <&cpg>; status = "disabled"; }; @@ -324,7 +322,6 @@ reg = <0xe803d000 0x30>; interrupts = <GIC_SPI 58 IRQ_TYPE_EDGE_RISING>; clocks = <&cpg CPG_MOD 34>; - clock-names = "ostm2"; power-domains = <&cpg>; status = "disabled"; };
Usually it does not hurt to add "clock-names" properties, even if the (pre-json-schema) DT bindings do not mention them. However, the actual clock names for the OS Timer nodes are not fixed, but contain the indices of the consumer instances. Hence they cannot easily be used by a driver, without scanning for all possible indices. Remove them, as the OSTM DT bindings do not specify clock-names anyway. Fixes: bbbcd02b82552907 ("ARM: dts: r7s9210: Initial SoC device tree") Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- To be queued in renesas-fixes for v5.7, to avoid the json-schema OSTM DT bindings conversion introducing a regression. --- arch/arm/boot/dts/r7s9210.dtsi | 3 --- 1 file changed, 3 deletions(-)