| Message ID | 20200525214958.30015-3-rikard.falkeborn@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drivers/iommu: Constify structs | expand |
On Mon, May 25, 2020 at 11:49:58PM +0200, Rikard Falkeborn wrote: > The struct sun50i_iommu_ops is not modified and can be made const to > allow the compiler to put it in read-only memory. > > Before: > text data bss dec hex filename > 14358 2501 64 16923 421b drivers/iommu/sun50i-iommu.o > > After: > text data bss dec hex filename > 14726 2117 64 16907 420b drivers/iommu/sun50i-iommu.o > > Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> Acked-by: Maxime Ripard <mripard@kernel.org> Thanks! Maxime
diff --git a/drivers/iommu/sun50i-iommu.c b/drivers/iommu/sun50i-iommu.c index 1fa09ddcebd4..fce605e96aa2 100644 --- a/drivers/iommu/sun50i-iommu.c +++ b/drivers/iommu/sun50i-iommu.c @@ -771,7 +771,7 @@ static int sun50i_iommu_of_xlate(struct device *dev, return iommu_fwspec_add_ids(dev, &id, 1); } -static struct iommu_ops sun50i_iommu_ops = { +static const struct iommu_ops sun50i_iommu_ops = { .pgsize_bitmap = SZ_4K, .attach_dev = sun50i_iommu_attach_device, .detach_dev = sun50i_iommu_detach_device,
The struct sun50i_iommu_ops is not modified and can be made const to allow the compiler to put it in read-only memory. Before: text data bss dec hex filename 14358 2501 64 16923 421b drivers/iommu/sun50i-iommu.o After: text data bss dec hex filename 14726 2117 64 16907 420b drivers/iommu/sun50i-iommu.o Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com> --- drivers/iommu/sun50i-iommu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)