| Message ID | 20200526105310.9706-2-mike.leach@linaro.org (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | 47446212832871e66f3b5fbf021c148eced2e24c |
| Headers | show |
| Series | perf: cs_etm: Allow no sink on command line. | expand |
On Tue, May 26, 2020 at 11:53:10AM +0100, Mike Leach wrote: > Adjust the handling of the session sink selection to allow no sink to > be selected on the command line. This then forwards the sink selection to > the CoreSight infrastructure which will attempt to select a sink based > on the default sink select priorities. > > Signed-off-by: Mike Leach <mike.leach@linaro.org> > --- > tools/perf/arch/arm/util/cs-etm.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c > index 941f814820b8..ed9ea2c60f27 100644 > --- a/tools/perf/arch/arm/util/cs-etm.c > +++ b/tools/perf/arch/arm/util/cs-etm.c > @@ -242,10 +242,10 @@ static int cs_etm_set_sink_attr(struct perf_pmu *pmu, > } > > /* > - * No sink was provided on the command line - for _now_ treat > - * this as an error. > + * No sink was provided on the command line - allow the CoreSight > + * system to look for a default > */ > - return ret; > + return 0; Leo added a tested-by for this patch. As I wrote on a previous patch we are currently in the middle of the merge window and as such this set needs to be rebased on v5.8-rc1 (when it comes out) and sent again. Thanks, Mathieu > } > > static int cs_etm_recording_options(struct auxtrace_record *itr, > -- > 2.17.1 >
diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c index 941f814820b8..ed9ea2c60f27 100644 --- a/tools/perf/arch/arm/util/cs-etm.c +++ b/tools/perf/arch/arm/util/cs-etm.c @@ -242,10 +242,10 @@ static int cs_etm_set_sink_attr(struct perf_pmu *pmu, } /* - * No sink was provided on the command line - for _now_ treat - * this as an error. + * No sink was provided on the command line - allow the CoreSight + * system to look for a default */ - return ret; + return 0; } static int cs_etm_recording_options(struct auxtrace_record *itr,
Adjust the handling of the session sink selection to allow no sink to be selected on the command line. This then forwards the sink selection to the CoreSight infrastructure which will attempt to select a sink based on the default sink select priorities. Signed-off-by: Mike Leach <mike.leach@linaro.org> --- tools/perf/arch/arm/util/cs-etm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)