| Message ID | 20200609105244.4014823-2-noltari@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bmips: add BCM63xx power domain controller | expand |
On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > --- > .../devicetree/bindings/mips/brcm/soc.txt | 17 +++++++++++++++++ You should probably create a YAML binding from the beginning that way you get validation for free. This file should ultimately be broken down into separate YAML bindings, but I Have not had the time to do that yet (you are welcome to if you feel like it). Other than that, the binding definition looks good to me.
Ok, I will send v2 with a separate YAML file. > El 10 jun 2020, a las 3:15, Florian Fainelli <f.fainelli@gmail.com> escribió: > > > > On 6/9/2020 3:52 AM, Álvaro Fernández Rojas wrote: >> BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller >> to enable/disable certain components in order to save power. >> >> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> >> --- >> .../devicetree/bindings/mips/brcm/soc.txt | 17 +++++++++++++++++ > > You should probably create a YAML binding from the beginning that way > you get validation for free. This file should ultimately be broken down > into separate YAML bindings, but I Have not had the time to do that yet > (you are welcome to if you feel like it). > > Other than that, the binding definition looks good to me. > -- > Florian
diff --git a/Documentation/devicetree/bindings/mips/brcm/soc.txt b/Documentation/devicetree/bindings/mips/brcm/soc.txt index 3a66d3c483e1..22ec9e39bff7 100644 --- a/Documentation/devicetree/bindings/mips/brcm/soc.txt +++ b/Documentation/devicetree/bindings/mips/brcm/soc.txt @@ -164,3 +164,20 @@ Example: reg = <0x4067c0 0x40>; interrupts = <&periph_intc 19>; }; + +BCM63xx +------- + += Power domain controller + +BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller +to enable/disable certain components in order to save power. + +- compatible : should contain one of: + "brcm,bcm6318-power-controller" + "brcm,bcm6328-power-controller" + "brcm,bcm6362-power-controller" + "brcm,bcm63268-power-controller" +- reg : the register start and length for the power domain + controller block +- #power-domain-cells : must be 1
BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller to enable/disable certain components in order to save power. Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> --- .../devicetree/bindings/mips/brcm/soc.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+)