| Message ID | 20200610171630.465579-2-noltari@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | bmips: add BCM63xx power domain controller | expand |
On Wed, 10 Jun 2020 19:16:22 +0200, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > --- > v3: fix reg maxItems and quote #power-domain-cells. > v2: Add separate YAML file. > > .../bindings/soc/bcm/brcm,bcm63xx-power.yaml | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml > My bot found errors running 'make dt_binding_check' on your patch: Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml: $id: relative path/filename doesn't match actual path or filename expected: http://devicetree.org/schemas/soc/bcm/brcm,bcm63xx-power.yaml# /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.example.dt.yaml: power-controller@10001848: reg: [[268441672, 4]] is too short See https://patchwork.ozlabs.org/patch/1307099 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On Wed, Jun 10, 2020 at 07:16:22PM +0200, Álvaro Fernández Rojas wrote: > BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > to enable/disable certain components in order to save power. > > Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com> > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > --- > v3: fix reg maxItems and quote #power-domain-cells. > v2: Add separate YAML file. > > .../bindings/soc/bcm/brcm,bcm63xx-power.yaml | 44 +++++++++++++++++++ Goes in bindings/power/ > 1 file changed, 44 insertions(+) > create mode 100644 Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml > > diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml > new file mode 100644 > index 000000000000..fd4204d9aaf6 > --- /dev/null > +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml > @@ -0,0 +1,44 @@ > +# SPDX-License-Identifier: GPL-2.0-or-later Okay with GPLv9? Dual license new bindings: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: "http://devicetree.org/schemas/soc/brcm/brcm,bcm63xx-power.yaml#" > +$schema: "http://devicetree.org/meta-schemas/core.yaml#" > + > +title: BCM63xx power domain driver > + > +maintainers: > + - Álvaro Fernández Rojas <noltari@gmail.com> > + > +description: | > + BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller > + to enable/disable certain components in order to save power. > + > +properties: > + compatible: > + items: > + - enum: > + - brcm,bcm6318-power-controller > + - brcm,bcm6328-power-controller > + - brcm,bcm6362-power-controller > + - brcm,bcm63268-power-controller > + > + reg: > + maxItems: 2 > + > + "#power-domain-cells": > + const: 1 > + > +required: > + - compatible > + - reg > + - "#power-domain-cells" > + > +additionalProperties: false > + > +examples: > + - | > + periph_pwr: power-controller@10001848 { > + compatible = "brcm,bcm6328-power-controller"; > + reg = <0x10001848 0x4>; > + #power-domain-cells = <1>; > + }; > -- > 2.26.2 >
diff --git a/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml new file mode 100644 index 000000000000..fd4204d9aaf6 --- /dev/null +++ b/Documentation/devicetree/bindings/soc/bcm/brcm,bcm63xx-power.yaml @@ -0,0 +1,44 @@ +# SPDX-License-Identifier: GPL-2.0-or-later +%YAML 1.2 +--- +$id: "http://devicetree.org/schemas/soc/brcm/brcm,bcm63xx-power.yaml#" +$schema: "http://devicetree.org/meta-schemas/core.yaml#" + +title: BCM63xx power domain driver + +maintainers: + - Álvaro Fernández Rojas <noltari@gmail.com> + +description: | + BCM6318, BCM6328, BCM6362 and BCM63268 SoCs have a power domain controller + to enable/disable certain components in order to save power. + +properties: + compatible: + items: + - enum: + - brcm,bcm6318-power-controller + - brcm,bcm6328-power-controller + - brcm,bcm6362-power-controller + - brcm,bcm63268-power-controller + + reg: + maxItems: 2 + + "#power-domain-cells": + const: 1 + +required: + - compatible + - reg + - "#power-domain-cells" + +additionalProperties: false + +examples: + - | + periph_pwr: power-controller@10001848 { + compatible = "brcm,bcm6328-power-controller"; + reg = <0x10001848 0x4>; + #power-domain-cells = <1>; + };