diff mbox series

[24/50] staging: vchi: Get rid of effect less expression

Message ID	20200623164235.29566-25-nsaenzjulienne@suse.de (mailing list archive)
State	New, archived
Headers	show Return-Path: <SRS0=C9iy=AE=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 53B8D20774 From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: gregkh@linuxfoundation.org Subject: [PATCH 24/50] staging: vchi: Get rid of effect less expression Date: Tue, 23 Jun 2020 18:42:10 +0200 Message-Id: <20200623164235.29566-25-nsaenzjulienne@suse.de> In-Reply-To: <20200623164235.29566-1-nsaenzjulienne@suse.de> References: <20200623164235.29566-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [195.135.220.15 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [195.135.220.15 listed in wl.mailspike.net] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Precedence: list Cc: devel@driverdev.osuosl.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, laurent.pinchart@ideasonboard.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
Series	staging: vchiq: Getting rid of the vchi/vchiq split \| expand [00/50] staging: vchiq: Getting rid of the vchi/vchiq split [01/50] staging: bcm2835: Break MMAL support out from camera [02/50] staging: mmal-vchiq: Allocate and free components as required [03/50] staging: mmal-vchiq: Avoid use of bool in structures [04/50] staging: mmal-vchiq: Make timeout a defined parameter [05/50] staging: mmal-vchiq: Make a mmal_buf struct for passing parameters [06/50] staging: mmal-vchiq: Fixup vchiq-mmal include ordering [07/50] staging: mmal-vchiq: Fix client_component for 64 bit kernel [08/50] staging: mmal-vchiq: Always return the param size from param_get [09/50] staging: mmal-vchiq: If the VPU returns an error, don't negate it [10/50] staging: mmal-vchiq: Fix formatting errors in mmal_parameters.h [11/50] staging: vchiq_arm: Add a matching unregister call [12/50] staging: vchi: Get rid of all useless callback reasons [13/50] staging: vchi: Get rid of vchi_msg_peek() [14/50] staging: vchi: Get rid of struct vchi_instance_handle [15/50] staging: vchi: Unify struct shim_service and struct vchi_service_handle [16/50] staging: vc04_services: bcm2835-audio: Use vchi_msg_hold() [17/50] staging: vchi: Get rid of vchi_msg_dequeue() [18/50] staging: vchi_common: Get rid of all unused definitions [19/50] staging: vchi: Get rid of unnecessary defines [20/50] staging: vc04_services: Get rid of vchi_cfg.h [21/50] staging: vchi: Get rid of flags argument in vchi_msg_hold() [22/50] staging: vchi: Use enum vchiq_bulk_mode instead of vchi's transmission flags [23/50] staging: vchi: Use vchiq's enum vchiq_reason [24/50] staging: vchi: Get rid of effect less expression [25/50] staging: vchiq: Introduce vchiq_validate_params() [26/50] staging: vchiq: Move message queue into struct vchiq_service [27/50] staging: vchiq: Get rid of vchiq_util.h [28/50] staging: vchi: Expose struct vchi_service [29/50] staging: vchiq: Export vchiq_get_service_userdata() [30/50] staging: vchiq: Export vchiq_msg_queue_push [31/50] staging: vchi: Get rid of vchiq_shim's message callback [32/50] staging: vchiq: Don't use a typedef for vchiq_callback [33/50] staging: vchi: Use struct vchiq_service_params [34/50] staging: vchi: Get rid of struct vchi_service [35/50] staging: vchiq: Pass vchiq's message when holding a message [36/50] staging: vchi: Rework vchi_msg_hold() to match vchiq_msg_hold() [37/50] staging: vchiq: Unify fourcc definition mechanisms [38/50] staging: vchi: Get rid of struct vchiq_instance forward declaration [39/50] staging: vchi: Don't include vchiq_core.h [40/50] staging: vchiq: Get rid of unnecessary definitions in vchiq_if.h [41/50] staging: vchiq: Make vchiq_add_service() local [42/50] staging: vchiq: Move definitions only used by core into core header [43/50] staging: vchi: Get rid of vchi_bulk_queue_receive() [44/50] staging: vchi: Get rid of vchi_bulk_queue_transmit() [45/50] staging: vchi: Move vchi_queue_kernel_message() into vchiq [46/50] staging: vchiq: Get rid of vchi [47/50] staging: vchiq: Move conditional barrier definition into vchiq_core.h [48/50] staging: vchiq: Use vchiq.h as the main header file for services [49/50] staging: vchiq: Move defines into core header [50/50] staging: vchiq: Move vchiq.h into include directory

Commit Message

Nicolas Saenz Julienne June 23, 2020, 4:42 p.m. UTC

It was probably there to trick compilers into ignoring unused variables,
which isn't needed in Linux.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox series

Patch

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index 649a65f02578..e09c595d6f9d 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -288,8 +288,6 @@  static struct vchi_service *service_alloc(struct vchiq_instance *instance,
 {
 	struct vchi_service *service = kzalloc(sizeof(struct vchi_service), GFP_KERNEL);
 
-	(void)instance;
-
 	if (service) {
 		if (!vchiu_queue_init(&service->queue, 64)) {
 			service->callback = setup->callback;