| Message ID | 20200624123330.83226-3-alex.popov@linux.com (mailing list archive) |
|---|---|
| State | Mainlined |
| Commit | ddfaf0e43e9bd4341dc2c24d48ac218f2fb1530a |
| Headers | show |
| Series | Improvements of the stackleak gcc plugin | expand |
On Wed, Jun 24, 2020 at 03:33:27PM +0300, Alexander Popov wrote: > Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to > avoid unneeded instrumentation. > > Signed-off-by: Alexander Popov <alex.popov@linux.com> But why is skipping it safe? Luis
On 24.06.2020 15:52, Luis Chamberlain wrote: > On Wed, Jun 24, 2020 at 03:33:27PM +0300, Alexander Popov wrote: >> Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to >> avoid unneeded instrumentation. >> >> Signed-off-by: Alexander Popov <alex.popov@linux.com> > > But why is skipping it safe? Hello Luis, Kees and Will discussed that in detail in v1 of the series: https://lore.kernel.org/lkml/20200610073046.GA15939@willie-the-truck/ Best regards, Alexander
On Wed, Jun 24, 2020 at 03:33:27PM +0300, Alexander Popov wrote: > Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to > avoid unneeded instrumentation. > > Signed-off-by: Alexander Popov <alex.popov@linux.com> Applied to for-next/gcc-plugins.
diff --git a/arch/arm/vdso/Makefile b/arch/arm/vdso/Makefile index d3c9f03e7e79..a54f70731d9f 100644 --- a/arch/arm/vdso/Makefile +++ b/arch/arm/vdso/Makefile @@ -29,7 +29,7 @@ CPPFLAGS_vdso.lds += -P -C -U$(ARCH) CFLAGS_REMOVE_vdso.o = -pg # Force -O2 to avoid libgcc dependencies -CFLAGS_REMOVE_vgettimeofday.o = -pg -Os +CFLAGS_REMOVE_vgettimeofday.o = -pg -Os $(GCC_PLUGINS_CFLAGS) ifeq ($(c-gettimeofday-y),) CFLAGS_vgettimeofday.o = -O2 else
Don't use gcc plugins for building arch/arm/vdso/vgettimeofday.c to avoid unneeded instrumentation. Signed-off-by: Alexander Popov <alex.popov@linux.com> --- arch/arm/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)