From patchwork Thu Jun 25 16:31:22 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625687 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4609A60D for ; Thu, 25 Jun 2020 16:33:56 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1E35320767 for ; Thu, 25 Jun 2020 16:33:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="F0xmJ/iq"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Vy09unAz" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1E35320767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=aIGEht7PZCj3m44CMTHmlAHU+g8S7EgbKeJWUXaTtt4=; b=F0xmJ/iqD8npv3nIYyBHEJHiX f6xeuXNy7mIUV2KARLWMqpc+H4HHfbNH9k55L5IcvB3i5JzRKXuw8Fsrw1NqIs4a9tCu7F/TUqNwY HgRj6di9OdH/i23SKgEXrIz8fyoUHS8OmtX6wt027GjSs4axEm0NpC0s2uTFJJcSrKez4kmnUxcVJ gcKGPOwCQZzcMWq/zzU9hEY60XAvw7OL9e46V87BuhRbcAQ+sAVymCz9RE7ldazXxWUPoggU2Csag gUq/YPJ8enpF1irNmNjwRKJjL9gITP9XSeZd1apnhhIEkbDWPNj0NpGuGs8f3fxeQt0wy5P2NanLQ Wb2Na6Dtw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUnK-00044Y-7h; Thu, 25 Jun 2020 16:32:10 +0000 Received: from mail-wr1-x444.google.com ([2a00:1450:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmq-0003uK-0S for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:40 +0000 Received: by mail-wr1-x444.google.com with SMTP id k6so6512917wrn.3 for ; Thu, 25 Jun 2020 09:31:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=XxI9BhAfrJpW+cNsrQPMJfGCyd0KQMsn+2Q7Z4q8M9M=; b=Vy09unAzWzBm7p/Z8sXAwDBEEE541im9XUsCyfot+2sgPnWxZ2Gk5OrQMMvieY77Os n/epknFjcJIi8dhWDYCm48+cKrTSOhhFZFRTka1gidFJj/xEKmZ376Hg68SNO7cxFWwq qN1OA9DfITpdWYPfEJzJZkw0NfW0chYPuKe3LzdaFOAXPXshL564Cs/+OjnXg0NrM6jD kecVxgzOY6jeUG18XeAXUkQg/YvYL5Qr+YJVNIizm52jJSF3PDN29Xo6olSalcDKCQrB 3hV8f/H3fYJ5QGtr1oU4rBXp3CTZsyppJIKcLX0Ja6oJ/BLNlTwztfq3p48PSogBaHrm Fa1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=XxI9BhAfrJpW+cNsrQPMJfGCyd0KQMsn+2Q7Z4q8M9M=; b=Br+ElFkehZO8KU02OtxdKqPIZBTIk6mOfy5YQww79KeWcyRZ/Gwqr25F/8i2EfdPgQ WLNSPY0edyOgi0+NLlZAfUkUtVtsjI34a6kPvPLQ3uCrogisXeeYnahDbQBkWIOsblkM AOnWxBr+X3YOohytos1Cx7Bp8Y3QHEruwT6aR/y68Mu7JmaQDYwn4yZJuQLFTDAn623c PNYmxZwoY/pV2fQ8dO6xhDiRLzzrdxS9qS2yHhTjdk87+dovh5IIkCHHvmX6XBNZSWsd SugzuBzIygR11Bqhu7dr0vhpTfpaVrCF4lwIe2Kaz3uO1u9q1S+P0Usk+V4ayRyPitJ1 DMAw== X-Gm-Message-State: AOAM530BqLmDUdJZxuJT0dkuijGk4wqXJlhNmUzp2Br1hlCOwIpsUEKY v/p/miCXmG8hoJL5jAkuhzBUUF22H3M= X-Google-Smtp-Source: ABdhPJxQcDZfTw8ATt3Q/S58X6QJDPiWu01vMmoV+iJw+tDAjnCJEPQ+9Ztl2EgWWXsNZTzZ1KeYEg== X-Received: by 2002:adf:8b5a:: with SMTP id v26mr37295310wra.165.1593102699140; Thu, 25 Jun 2020 09:31:39 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:38 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 05/10] mfd: tps65010: Remove delcared and set, but never used variable 'status' Date: Thu, 25 Jun 2020 17:31:22 +0100 Message-Id: <20200625163127.4000462-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:444 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org 'status' hasn't been checked since 2008. It's probably safe to remove it. Fixes W=1 warning: drivers/mfd/tps65010.c:407:7: warning: variable ‘status’ set but not used [-Wunused-but-set-variable] 407 | int status; | ^~~~~~ Signed-off-by: Lee Jones --- drivers/mfd/tps65010.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/tps65010.c b/drivers/mfd/tps65010.c index 65fcc58c02da8..7e7dbee58ca90 100644 --- a/drivers/mfd/tps65010.c +++ b/drivers/mfd/tps65010.c @@ -404,7 +404,6 @@ static void tps65010_work(struct work_struct *work) tps65010_interrupt(tps); if (test_and_clear_bit(FLAG_VBUS_CHANGED, &tps->flags)) { - int status; u8 chgconfig, tmp; chgconfig = i2c_smbus_read_byte_data(tps->client, @@ -415,8 +414,8 @@ static void tps65010_work(struct work_struct *work) else if (tps->vbus >= 100) chgconfig |= TPS_VBUS_CHARGING; - status = i2c_smbus_write_byte_data(tps->client, - TPS_CHGCONFIG, chgconfig); + i2c_smbus_write_byte_data(tps->client, + TPS_CHGCONFIG, chgconfig); /* vbus update fails unless VBUS is connected! */ tmp = i2c_smbus_read_byte_data(tps->client, TPS_CHGCONFIG);