From patchwork Thu Jun 25 16:31:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11625699 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id A4BBC138C for ; Thu, 25 Jun 2020 16:34:04 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7E08420767 for ; Thu, 25 Jun 2020 16:34:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="RG3gP5Wu"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Rsf1N6yX" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7E08420767 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=3IkeRe/LL5l8d3JIlbYCERWw5oEpxmheR1ud3o5Zrf4=; b=RG3gP5WutM2rUPPQllqrMZL/c /UHBxW3boLLosHEhAbqRqXKCQdat59dRuPnwW22+pgOx/iZFn7NgVANMfJv1D3ZITggtgowB39PB6 n0DB1PqkV8Q88Z9xeDwjGJ8eTQpL51o6Dv3GoZWEOsvmiwzlUJ/tDfp4G+djNeTAenohWHGZMkmQl 8e6MCYgXQ1t2frG8TSPDYWsZO7nqqNdIfAEafreKmtkSyGeuBkDB8pYtuXQTgjF2xTjlc5aWJukcp 7k58/uoCJBSS6UzIZPfJfFWzOaCSTVq9Us0O3ZHdRqeM+TtLMyA+G9tvnqM2/HQ7+NiPFJqOjt8oG dsyR1aGfg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUnN-00045x-3J; Thu, 25 Jun 2020 16:32:13 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1joUmr-0003un-3Y for linux-arm-kernel@lists.infradead.org; Thu, 25 Jun 2020 16:31:42 +0000 Received: by mail-wm1-x344.google.com with SMTP id l2so5111478wmf.0 for ; Thu, 25 Jun 2020 09:31:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=rS9j2rQNFBNuRqF+LXK8DlVraMrXmRrORbc3erknD/A=; b=Rsf1N6yX7IxQGRLHSgXSpJP/QPbCuo2R1yR5hRp/jiWLAjlOONAIfPujcEjKgSdHQq HCdTJkdvd5BFjh1Bf4cFe8BzerfwN1dBFhQUFxF2l/p1UxJkuvzb87JUP9Toy1Dy2axP a0LXFQn4VuxV6m0LMVFRM7zV0Uc8Z7kDndCgJbFlhEyRA0LwFTWA5a6HeDrPOr1yYDD0 zLqv5Mi39CHmn58FiUh2XnxGJdysqcpFfOV7VH5Ll6rpkZHvKIPTXw3GtnCZ+KGLOvMG hjQBHX76GS7NR1yBcE561TiGBTocOaLGrfvZnmZqg7tfQe775ibW+ZCGKNSY7nrv4GFD KOIQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=rS9j2rQNFBNuRqF+LXK8DlVraMrXmRrORbc3erknD/A=; b=uPcAKQMI3Jk+GcQcdKBOq1cEL2VztL6pV3KHme1bpCS4UXhcgcyrdbthi1OUgFEDA1 pIKxatRtlSvpshFnLNdMkRwb6I0/dVsQnQJ+xMyLQ1SdpCq6wUGt/IXLoT0KmbyxGBby 0Q9CB5PqrE/YZan3jfUS55i6j8BwfZ6BLcWUzjXu2B04GARWwZk49zXwOM+Hi1AzTjIV /6FR2WoibS+oZk6+7u1eaECIg751apy16l3YwMKgFfJQOI+vnl0Cq3efHvQXlp8/6r80 Cu7HNEEG+rwn4GY3jM0rB5cfYflYECCDLwbO3B3btzu+WIYqBQmbPQUDBEmz+pco3nul utaw== X-Gm-Message-State: AOAM532NGzbRFhhkhicKAI/SjHCprPXRcNFwzkzXQ0WeAgGsi7Ut2zyB FPwfDv78dAPc0flI0QVm8cM5LuqQnSk= X-Google-Smtp-Source: ABdhPJzhQiFSSOZa69VFgcR0DY0GlXvIC6q9WGt36h5eMePZdVb++c5OYhmvra/vUdFSxkb68YaCJQ== X-Received: by 2002:a7b:c76a:: with SMTP id x10mr4312440wmk.16.1593102700156; Thu, 25 Jun 2020 09:31:40 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id l8sm32090847wrq.15.2020.06.25.09.31.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Jun 2020 09:31:39 -0700 (PDT) From: Lee Jones To: lee.jones@linaro.org Subject: [PATCH 06/10] mfd: si476x-cmd: Repair wrongly described function argument 's/response/resp' Date: Thu, 25 Jun 2020 17:31:23 +0100 Message-Id: <20200625163127.4000462-7-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200625163127.4000462-1-lee.jones@linaro.org> References: <20200625163127.4000462-1-lee.jones@linaro.org> MIME-Version: 1.0 X-Spam-Note: CRM114 invocation failed X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:344 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andrey Smirnov , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org si476x_core_send_command()'s 5th argument has never been called response. This change must have occurred prior to the driver being Mainlined. We're also taking the opportunity to bring the first description back into line, making my OCD happy! This fixes the following W=1 warning(s): drivers/mfd/si476x-cmd.c:264: warning: Function parameter or member 'resp' not described in 'si476x_core_send_command drivers/mfd/si476x-cmd.c:264: warning: Excess function parameter 'response' description in 'si476x_core_send_command' Cc: Andrey Smirnov Signed-off-by: Lee Jones --- drivers/mfd/si476x-cmd.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/mfd/si476x-cmd.c b/drivers/mfd/si476x-cmd.c index 4a09ce9609c90..316d44c2edcd4 100644 --- a/drivers/mfd/si476x-cmd.c +++ b/drivers/mfd/si476x-cmd.c @@ -241,13 +241,13 @@ static int si476x_core_parse_and_nag_about_error(struct si476x_core *core) /** * si476x_core_send_command() - sends a command to si476x and waits its * response - * @core: si476x_device structure for the device we are + * @core: si476x_device structure for the device we are * communicating with * @command: command id * @args: command arguments we are sending * @argn: actual size of @args - * @response: buffer to place the expected response from the device - * @respn: actual size of @response + * @resp: buffer to place the expected response from the device + * @respn: actual size of @resp * @usecs: amount of time to wait before reading the response (in * usecs) *