diff mbox series

[v2,21/47] staging: vchi: Get rid of effect less expression

Message ID	20200629150945.10720-22-nsaenzjulienne@suse.de (mailing list archive)
State	Mainlined
Commit	6c53da0b2ff9df002ff8e8e65ddf9e011e5527a6
Headers	show Return-Path: <SRS0=SqQd=AK=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 74E2323EB0 From: Nicolas Saenz Julienne <nsaenzjulienne@suse.de> To: gregkh@linuxfoundation.org Subject: [PATCH v2 21/47] staging: vchi: Get rid of effect less expression Date: Mon, 29 Jun 2020 17:09:19 +0200 Message-Id: <20200629150945.10720-22-nsaenzjulienne@suse.de> In-Reply-To: <20200629150945.10720-1-nsaenzjulienne@suse.de> References: <20200629150945.10720-1-nsaenzjulienne@suse.de> MIME-Version: 1.0 summary: Content analysis details: (-2.3 points) pts rule name description ---- ---------------------- -------------------------------------------------- -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [195.135.220.15 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H3 RBL: Good reputation (+3) [195.135.220.15 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders Precedence: list Cc: devel@driverdev.osuosl.org, kernel-list@raspberrypi.com, linux-kernel@vger.kernel.org, Nicolas Saenz Julienne <nsaenzjulienne@suse.de>, laurent.pinchart@ideasonboard.com, linux-arm-kernel@lists.infradead.org, linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org
Series	staging: vchiq: Getting rid of the vchi/vchiq split \| expand [v2,00/47] staging: vchiq: Getting rid of the vchi/vchiq split [v2,01/47] staging: mmal-vchiq: Make timeout a defined parameter [v2,02/47] staging: mmal-vchiq: Make a mmal_buf struct for passing parameters [v2,03/47] staging: mmal-vchiq: Fixup vchiq-mmal include ordering [v2,04/47] staging: mmal-vchiq: Fix client_component for 64 bit kernel [v2,05/47] staging: mmal-vchiq: Always return the param size from param_get [v2,06/47] staging: mmal-vchiq: If the VPU returns an error, don't negate it [v2,07/47] staging: mmal-vchiq: Fix formatting errors in mmal_parameters.h [v2,08/47] staging: vchiq_arm: Add a matching unregister call [v2,09/47] staging: vchi: Get rid of all useless callback reasons [v2,10/47] staging: vchi: Get rid of vchi_msg_peek() [v2,11/47] staging: vchi: Get rid of struct vchi_instance_handle [v2,12/47] staging: vchi: Unify struct shim_service and struct vchi_service_handle [v2,13/47] staging: vc04_services: bcm2835-audio: Use vchi_msg_hold() [v2,14/47] staging: vchi: Get rid of vchi_msg_dequeue() [v2,15/47] staging: vchi_common: Get rid of all unused definitions [v2,16/47] staging: vchi: Get rid of unnecessary defines [v2,17/47] staging: vc04_services: Get rid of vchi_cfg.h [v2,18/47] staging: vchi: Get rid of flags argument in vchi_msg_hold() [v2,19/47] staging: vchi: Use enum vchiq_bulk_mode instead of vchi's transmission flags [v2,20/47] staging: vchi: Use vchiq's enum vchiq_reason [v2,21/47] staging: vchi: Get rid of effect less expression [v2,22/47] staging: vchiq: Introduce vchiq_validate_params() [v2,23/47] staging: vchiq: Move message queue into struct vchiq_service [v2,24/47] staging: vchiq: Get rid of vchiq_util.h [v2,25/47] staging: vchi: Expose struct vchi_service [v2,26/47] staging: vchiq: Export vchiq_get_service_userdata() [v2,27/47] staging: vchiq: Export vchiq_msg_queue_push [v2,28/47] staging: vchi: Get rid of vchiq_shim's message callback [v2,29/47] staging: vchiq: Don't use a typedef for vchiq_callback [v2,30/47] staging: vchi: Use struct vchiq_service_params [v2,31/47] staging: vchi: Get rid of struct vchi_service [v2,32/47] staging: vchiq: Pass vchiq's message when holding a message [v2,33/47] staging: vchi: Rework vchi_msg_hold() to match vchiq_msg_hold() [v2,34/47] staging: vchiq: Unify fourcc definition mechanisms [v2,35/47] staging: vchi: Get rid of struct vchiq_instance forward declaration [v2,36/47] staging: vchi: Don't include vchiq_core.h [v2,37/47] staging: vchiq: Get rid of unnecessary definitions in vchiq_if.h [v2,38/47] staging: vchiq: Make vchiq_add_service() local [v2,39/47] staging: vchiq: Move definitions only used by core into core header [v2,40/47] staging: vchi: Get rid of vchi_bulk_queue_receive() [v2,41/47] staging: vchi: Get rid of vchi_bulk_queue_transmit() [v2,42/47] staging: vchi: Move vchi_queue_kernel_message() into vchiq [v2,43/47] staging: vchiq: Get rid of vchi [v2,44/47] staging: vchiq: Move conditional barrier definition into vchiq_core.h [v2,45/47] staging: vchiq: Use vchiq.h as the main header file for services [v2,46/47] staging: vchiq: Move defines into core header [v2,47/47] staging: vchiq: Move vchiq.h into include directory

Commit Message

Nicolas Saenz Julienne June 29, 2020, 3:09 p.m. UTC

It was probably there to trick compilers into ignoring unused variables,
which isn't needed in Linux.

Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
---
 drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c | 2 --
 1 file changed, 2 deletions(-)

diff mbox series

Patch

diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
index f2998c0ca5b1..b4884d0b82cd 100644
--- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
+++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_shim.c
@@ -288,8 +288,6 @@  static struct vchi_service *service_alloc(struct vchiq_instance *instance,
 {
 	struct vchi_service *service = kzalloc(sizeof(struct vchi_service), GFP_KERNEL);
 
-	(void)instance;
-
 	if (service) {
 		if (!vchiu_queue_init(&service->queue, 64)) {
 			service->callback = setup->callback;