[v2] drivers/firmware/psci: Assign @err directly in hotplug_tests()

Commit Message

Gavin Shan June 30, 2020, 7:59 a.m. UTC

The return value of down_and_up_cpus() can be assigned to @err directly.
With that, the useless assignment to @err with zero can be dropped.

Signed-off-by: Gavin Shan <[e-mail]>
Reviewed-by: Sudeep Holla <[e-mail]>
---
v2: Pick r-b from Sudeep and rebase to 5.8.rc3
---
 drivers/firmware/psci/psci_checker.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Will Deacon July 8, 2020, 10:02 p.m. UTC | #1

On Tue, 30 Jun 2020 17:59:43 +1000, Gavin Shan wrote:
> The return value of down_and_up_cpus() can be assigned to @err directly.
> With that, the useless assignment to @err with zero can be dropped.

Applied to arm64 (for-next/fixes), thanks!

[1/1] drivers/firmware/psci: Assign @err directly in hotplug_tests()
      https://git.kernel.org/arm64/c/132330f8044c

Cheers,

Patch

diff --git a/drivers/firmware/psci/psci_checker.c b/drivers/firmware/psci/psci_checker.c
index d9b1a2d71223..3d6ba425dbb9 100644
--- a/drivers/firmware/psci/psci_checker.c
+++ b/drivers/firmware/psci/psci_checker.c
@@ -199,13 +199,12 @@  static int hotplug_tests(void)
 	if (!page_buf)
 		goto out_free_cpu_groups;
 
-	err = 0;
 	/*
 	 * Of course the last CPU cannot be powered down and cpu_down() should
 	 * refuse doing that.
 	 */
 	pr_info("Trying to turn off and on again all CPUs\n");
-	err += down_and_up_cpus(cpu_online_mask, offlined_cpus);
+	err = down_and_up_cpus(cpu_online_mask, offlined_cpus);
 
 	/*
 	 * Take down CPUs by cpu group this time. When the last CPU is turned