| Message ID | 20200701162928.1638874-3-megous@megous.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add support for PinePhone LCD panel | expand |
On Wed, 01 Jul 2020 18:29:17 +0200, Ondrej Jirman wrote: > Convert Rocktech MIPI DSI panel driver from txt to yaml bindings. > > Signed-off-by: Ondrej Jirman <megous@megous.com> > --- > .../display/panel/rocktech,jh057n00900.txt | 23 ------- > .../display/panel/rocktech,jh057n00900.yaml | 66 +++++++++++++++++++ > 2 files changed, 66 insertions(+), 23 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt > create mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml > My bot found errors running 'make dt_binding_check' on your patch: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property See https://patchwork.ozlabs.org/patch/1320690 If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure dt-schema is up to date: pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade Please check and re-submit.
On Thu, Jul 02, 2020 at 02:51:43PM -0600, Rob Herring wrote: > On Wed, 01 Jul 2020 18:29:17 +0200, Ondrej Jirman wrote: > > Convert Rocktech MIPI DSI panel driver from txt to yaml bindings. > > > > Signed-off-by: Ondrej Jirman <megous@megous.com> > > --- > > .../display/panel/rocktech,jh057n00900.txt | 23 ------- > > .../display/panel/rocktech,jh057n00900.yaml | 66 +++++++++++++++++++ > > 2 files changed, 66 insertions(+), 23 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt > > create mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property Paths look bogus ^^^^ It should be .../rocktech,jh057n00900.yaml: ... regards, o. > > See https://patchwork.ozlabs.org/patch/1320690 > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure dt-schema is up to date: > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > Please check and re-submit. >
Hi Ondrej. > > My bot found errors running 'make dt_binding_check' on your patch: > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property > > Paths look bogus ^^^^ > > It should be .../rocktech,jh057n00900.yaml: ... The example in nwl-dsi.yaml contains: compatible = "rocktech,jh057n00900"; So the example is checked against your updated binding. And the binding check fails because the example is no longer valid. This needs to be fixed as we do not wat to introduce new errors. Either the example or the binding needs the fix. Sam > > regards, > o. > > > > > See https://patchwork.ozlabs.org/patch/1320690 > > > > If you already ran 'make dt_binding_check' and didn't see the above > > error(s), then make sure dt-schema is up to date: > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > Please check and re-submit. > >
Hello Sam, On Fri, Jul 03, 2020 at 07:11:55AM +0200, Sam Ravnborg wrote: > Hi Ondrej. > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property > > > > Paths look bogus ^^^^ > > > > It should be .../rocktech,jh057n00900.yaml: ... > > The example in nwl-dsi.yaml contains: > compatible = "rocktech,jh057n00900"; > > So the example is checked against your updated binding. > And the binding check fails because the example is no longer valid. Ah, now I understand. > This needs to be fixed as we do not wat to introduce new errors. > Either the example or the binding needs the fix. I think we can unrequire the supplies, but reset is needed really. The panel only has one port, so there should be no address/size-cells in the example, and port@0 should be just port to match existing binding. If it had multiple ports, port@0 would have to be inside ports { } node anyway, according to the existing binding. Then add reset-gpios to the example... And that should fix it. I'll prepare the patch shortly. regards, o. > Sam > > > > > > regards, > > o. > > > > > > > > See https://patchwork.ozlabs.org/patch/1320690 > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure dt-schema is up to date: > > > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > > > Please check and re-submit. > > >
On Fri, Jul 03, 2020 at 12:44:48PM +0200, megous hlavni wrote: > Hello Sam, > > On Fri, Jul 03, 2020 at 07:11:55AM +0200, Sam Ravnborg wrote: > > Hi Ondrej. > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: '#address-cells', '#size-cells', 'port@0' do not match any of the regexes: 'pinctrl-[0-9]+' > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'vcc-supply' is a required property > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'iovcc-supply' is a required property > > > > /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/display/bridge/nwl-dsi.example.dt.yaml: panel@0: 'reset-gpios' is a required property > > > > > > Paths look bogus ^^^^ > > > > > > It should be .../rocktech,jh057n00900.yaml: ... > > > > The example in nwl-dsi.yaml contains: > > compatible = "rocktech,jh057n00900"; > > > > So the example is checked against your updated binding. > > And the binding check fails because the example is no longer valid. > > Ah, now I understand. > > > This needs to be fixed as we do not wat to introduce new errors. > > Either the example or the binding needs the fix. > > I think we can unrequire the supplies, but reset is needed really. Hmm, that's probably wrong kind of thinking. Panel has the supplies, and obviously requires them, so the dts must describe them somehow, even if they are the fixed supplies. So I'll not unrequire them. > The panel only has one port, so there should be no address/size-cells > in the example, and port@0 should be just port to match existing binding. > If it had multiple ports, port@0 would have to be inside ports { } node > anyway, according to the existing binding. Then add reset-gpios to > the example... > > And that should fix it. > > I'll prepare the patch shortly. > > regards, > o. > > > Sam > > > > > > > > > > regards, > > > o. > > > > > > > > > > > See https://patchwork.ozlabs.org/patch/1320690 > > > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > > error(s), then make sure dt-schema is up to date: > > > > > > > > pip3 install git+https://github.com/devicetree-org/dt-schema.git@master --upgrade > > > > > > > > Please check and re-submit. > > > >
diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt deleted file mode 100644 index a372c5d84695..000000000000 --- a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt +++ /dev/null @@ -1,23 +0,0 @@ -Rocktech jh057n00900 5.5" 720x1440 TFT LCD panel - -Required properties: -- compatible: should be "rocktech,jh057n00900" -- reg: DSI virtual channel of the peripheral -- reset-gpios: panel reset gpio -- backlight: phandle of the backlight device attached to the panel -- vcc-supply: phandle of the regulator that provides the vcc supply voltage. -- iovcc-supply: phandle of the regulator that provides the iovcc supply - voltage. - -Example: - - &mipi_dsi { - panel@0 { - compatible = "rocktech,jh057n00900"; - reg = <0>; - backlight = <&backlight>; - reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>; - vcc-supply = <®_2v8_p>; - iovcc-supply = <®_1v8_p>; - }; - }; diff --git a/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml new file mode 100644 index 000000000000..928ba42e7f8d --- /dev/null +++ b/Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml @@ -0,0 +1,66 @@ +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/display/panel/rocktech,jh057n00900.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Rocktech JH057N00900 5.5" 720x1440 TFT LCD panel + +maintainers: + - Ondrej Jirman <megi@xff.cz> + +description: | + Rocktech JH057N00900 is a 720x1440 TFT LCD panel + connected using a MIPI-DSI video interface. + +allOf: + - $ref: panel-common.yaml# + +properties: + compatible: + const: rocktech,jh057n00900 + + reg: + maxItems: 1 + description: DSI virtual channel + + vcc-supply: + description: Panel power supply + + iovcc-supply: + description: I/O voltage supply + + reset-gpios: + description: GPIO used for the reset pin + maxItems: 1 + + backlight: + description: Backlight used by the panel + $ref: "/schemas/types.yaml#/definitions/phandle" + +required: + - compatible + - reg + - vcc-supply + - iovcc-supply + - reset-gpios + +additionalProperties: false + +examples: + - | + #include <dt-bindings/gpio/gpio.h> + + dsi { + #address-cells = <1>; + #size-cells = <0>; + panel@0 { + compatible = "rocktech,jh057n00900"; + reg = <0>; + vcc-supply = <®_2v8_p>; + iovcc-supply = <®_1v8_p>; + reset-gpios = <&gpio3 13 GPIO_ACTIVE_LOW>; + backlight = <&backlight>; + }; + }; +...
Convert Rocktech MIPI DSI panel driver from txt to yaml bindings. Signed-off-by: Ondrej Jirman <megous@megous.com> --- .../display/panel/rocktech,jh057n00900.txt | 23 ------- .../display/panel/rocktech,jh057n00900.yaml | 66 +++++++++++++++++++ 2 files changed, 66 insertions(+), 23 deletions(-) delete mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.txt create mode 100644 Documentation/devicetree/bindings/display/panel/rocktech,jh057n00900.yaml