Message ID | 20200702144625.2533530-23-lee.jones@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=gbIi=AN=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 67ED76C1 for <patchwork-linux-arm@patchwork.kernel.org>; Thu, 2 Jul 2020 14:54:26 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D331C2089D for <patchwork-linux-arm@patchwork.kernel.org>; Thu, 2 Jul 2020 14:54:25 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yg26VYpv"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="c53RgvRD" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D331C2089D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=H3SfYD5PcB0bq4myp5UiReg9JEC330JlMS6+J8pH22w=; b=yg26VYpvvVlUO54Fc+kbfv+P4 CXL4+GwdOw8D8ZN6GiedShQsD7daytNSxSFxnwlL/zIz82ZdxT8xr60bxJkzhSTvUHoeNV06LHQW6 qV8Tmip6d4iEL2uQBxTfE9jwddtXGTgus/K2XYOrtz7EGawfZlkY0ZKNNHInXXKeW7ueafFqC4hpA WAxKTcwkAbDrNFwf6jeDWCEjl639SN3Plidu0Rnd+Y9Y4OHWL2Uq3aDDM5pNUuReDPDpzX9UDPt1i FNjQTXxPvPvKcFPi6RYHf4YpyAyaqdzEDH3CCyplgcPR0jKg/P7gs1yq7B8cCc623NAICrOsbeGq5 kbRcJdqxA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr0Yt-0008Kd-0b; Thu, 02 Jul 2020 14:51:39 +0000 Received: from mail-wm1-x343.google.com ([2a00:1450:4864:20::343]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jr0UO-0005Q1-Mv for linux-arm-kernel@lists.infradead.org; Thu, 02 Jul 2020 14:47:04 +0000 Received: by mail-wm1-x343.google.com with SMTP id j18so27094962wmi.3 for <linux-arm-kernel@lists.infradead.org>; Thu, 02 Jul 2020 07:46:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=H2cePmcpx5tsP4U3KYd+LqwzZEatzdvDVRzwm5J/30A=; b=c53RgvRD10yT154GgQgeIyna2QYPrbkI+WTnp2UMoFo9CT36rTCyqrDngBqvuckw3S +oNa3YdgsimKjvPoCH/30TsKQMdDJPLwl5KHWSs/fy5BFSSaYO5/F8t+s9fUmd1kfbTt joQnwQce5qZ1EBcSIkEdbgflYXu4hOxUS6yHZw1bkvsDOdZNN1Lvp9vhf7mjC2cttpwR UMLjHgsZgsLUt6CM3mwFLJczW2/G2TFbYlK31eHuAJ0WUZDimWF74sk72FwUIAoR9soG 5nDZgi3NL2ZhkzfWwoPAK4IyiU44YXnPmkhwRZ/mQsAqgQkNxutA+aNeEwTG27koO4xd N+ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=H2cePmcpx5tsP4U3KYd+LqwzZEatzdvDVRzwm5J/30A=; b=Nq56+vh6XPuT8KtcObEDK0Qn49VNq8ZDWHXC7BfzzL+/BEvrgci02SPjhUnlLe7bXb 6xI64dycIsLlmV69UXeYMtUcDKExnCOPWSZg7P2/34DCthlh6AJSyXJugo5gOTqGm705 0ROcXsnXHfzlZUabqsTfooZfbNfbI4L0YMIXk/KNTwU9KT6yzw0FpyH6rpTNi1hFazj2 GByfRO2N6skkJR3oBUubuWnZl5rvzHm8JIJaWyofu/j92rDEC3kwNKodhKubkYDh+cGL lZkQLViyXLNAr5XjxTG+zpRucr1raygDXxrwGHeATlJvoZzkjyWxewqcVT6rgLyJWXP/ k50g== X-Gm-Message-State: AOAM531WJPDnz5SS8ZIeGnVgCgJLphdU4498BGiZxSosp+uW4CzZNYuk ecA8wy7+DD/o8EDpLRklLQqu8Izn5vs= X-Google-Smtp-Source: ABdhPJw0wDnk30+GzymRe6m8MX4bgQkP+1HG/vAC/QIiYL0ssvI94FAnR4CJhMTZpP/sPRSbJk6tYA== X-Received: by 2002:a7b:c775:: with SMTP id x21mr17240384wmk.34.1593701218885; Thu, 02 Jul 2020 07:46:58 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id g14sm7002737wrw.83.2020.07.02.07.46.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 Jul 2020 07:46:58 -0700 (PDT) From: Lee Jones <lee.jones@linaro.org> To: gregkh@linuxfoundation.org Subject: [PATCH 22/30] usb: cdns3: ep0: Move 'zlp' description to appropriate function header Date: Thu, 2 Jul 2020 15:46:17 +0100 Message-Id: <20200702144625.2533530-23-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200702144625.2533530-1-lee.jones@linaro.org> References: <20200702144625.2533530-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200702_104700_873647_C56B0DB0 X-CRM114-Status: GOOD ( 13.89 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:343 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Peter Chen <peter.chen@nxp.com>, Pawel Laszczak <pawell@cadence.com>, Pawel Jez <pjez@cadence.com>, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, Lee Jones <lee.jones@linaro.org>, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org |
Series |
Fix a bunch of W=1 issues in USB
|
expand
|
diff --git a/drivers/usb/cdns3/ep0.c b/drivers/usb/cdns3/ep0.c index 5b3f682338e50..5b1aec80b2d7f 100644 --- a/drivers/usb/cdns3/ep0.c +++ b/drivers/usb/cdns3/ep0.c @@ -29,6 +29,7 @@ static struct usb_endpoint_descriptor cdns3_gadget_ep0_desc = { * @length: data length * @erdy: set it to 1 when ERDY packet should be sent - * exit from flow control state + * @zlp: add zero length packet */ static void cdns3_ep0_run_transfer(struct cdns3_device *priv_dev, dma_addr_t dma_addr, @@ -695,7 +696,6 @@ static int cdns3_gadget_ep0_set_halt(struct usb_ep *ep, int value) * @ep: pointer to endpoint zero object * @request: pointer to request object * @gfp_flags: gfp flags - * @zlp: add zero length packet * * Returns 0 on success, error code elsewhere */
'zlp' was documented, but in the wrong place. Fixes the following W=1 kernel build warning(s): drivers/usb/cdns3/ep0.c:36: warning: Function parameter or member 'zlp' not described in 'cdns3_ep0_run_transfer' drivers/usb/cdns3/ep0.c:705: warning: Excess function parameter 'zlp' description in 'cdns3_gadget_ep0_queue' Cc: Pawel Laszczak <pawell@cadence.com> Cc: Pawel Jez <pjez@cadence.com> Cc: Peter Chen <peter.chen@nxp.com> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/usb/cdns3/ep0.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)