Message ID | 20200703174148.2749969-6-lee.jones@linaro.org (mailing list archive) |
---|---|
State | New, archived |
Headers | show
Return-Path: <SRS0=BGfW=AO=lists.infradead.org=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@kernel.org> Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7D33E159A for <patchwork-linux-arm@patchwork.kernel.org>; Fri, 3 Jul 2020 17:44:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5554E20870 for <patchwork-linux-arm@patchwork.kernel.org>; Fri, 3 Jul 2020 17:44:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="ggRf90Uh"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vxZsHJwv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5554E20870 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=77quErI6Lf7sf8MNEZMZpHNol88+/HOyAa1D1xUEwZc=; b=ggRf90Uhw5JaaRET8lJARo6F0 NiNGLUl7Dzn1XxEK57v59fy/z3wr63xH97L+AV6P7geELwaMTZ/XrvK6Ii+Y2JnSypQedCjP3rQGO O+q7klpXcpYNuq6eeXfmF6Izhz1z1GmceEfjJdV57jUP+neLdKogUMtbUaf8RaKauR7WgupdcgXLV ciATKMgTcEvv/DGDTf34CLlI0ij7TU4B9J9kCBCLcbruOTLrFMiy6wE9DuUgG+IBHtqvsDJRpwEv9 iBkW6/83WSrAN4q8ykt3KQQcOM+EwgJ97aNMAe79shJvrtGWfYsZ8v9LWq7PQu3rpmz7APgIacn89 vb8WAC2zw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrPhf-00020d-Ej; Fri, 03 Jul 2020 17:42:23 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jrPhO-0001tO-46 for linux-arm-kernel@lists.infradead.org; Fri, 03 Jul 2020 17:42:07 +0000 Received: by mail-wm1-x341.google.com with SMTP id 17so34829618wmo.1 for <linux-arm-kernel@lists.infradead.org>; Fri, 03 Jul 2020 10:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=As8A0RVzBKjotvgXeoxk2ZtBQ/Bg0sCNtYggCVfAltY=; b=vxZsHJwvvgk09IRk1MBBvInd06xDFaXaJSvUjtd1st5QBwE7HyMKZH7jepYLljpcQg zUHRMk04EnmsYB1tHOAEOToKbahfZNCxa2IgNpGUJzAY8RUNWCNGf5YJiWejTxgPu1E/ 0DNDIRZTdlSOPBhE42KiXRHEn84U1+zcJqILDik1LWMAVQR4OwHllAkevRZJAAxCxPdY Yrs0IHBWbngpyzHbb5g2+htPJdQxKakwoR0jr3Mtt3yPL6c8ag7wc5DkOdqUDX/rJBUU oD+k+3a0jVUSk5VbS3zeYPCF2xo/5RD7A7aQnMB21Z+a6om5KhL9zryyYKpkaJlLrsFB AacA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=As8A0RVzBKjotvgXeoxk2ZtBQ/Bg0sCNtYggCVfAltY=; b=KizC25ExdQ7r5RbRuE+kwo7ZmPZRszZ56APyXw4cXZnGEtHOOvqe8RYz3RWC0gR2lQ uFWzHyrsNc2fPY9aPC8u0jkGcYJVrkCEezgrC5h4G69NHBhUOvpyVgqo1jjy5nq0Xy+2 2Ep/DDZ/uAh6BlHpiWpbhXyh7w12wykEFy5Gwmh3lxtAa5q8bESajjQx8H7UUwfhfpkw IyfcF+CdzOAWqTwkUrfL2RLn/mazncqCI+iC4V9IXmNj2I+5JmPHiB0CWKFuVyF16B5i 06lkSaCPsJ3CYXL3iAWfwb0Ol3b0yf1fSyJQKPQxMIlq0DmsUzZ/Y5KEa+e3ObdkLuij W2FQ== X-Gm-Message-State: AOAM532Te9BUgaw5TqstRBQ00IBcxfqKwxVKgsf7In1g7E/C95NDM3fu ZRg/Jy7MVW/pKanwGYWUOxFuzQ== X-Google-Smtp-Source: ABdhPJwolAxrC9FaOIOAI5J97mqd3etXuXAGwhxu+GQ5gnBfEv/QxrYF0gQrtBPhDn4CwIqSE6hE0g== X-Received: by 2002:a1c:398b:: with SMTP id g133mr36495525wma.76.1593798125273; Fri, 03 Jul 2020 10:42:05 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id x11sm13625799wmc.26.2020.07.03.10.42.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 03 Jul 2020 10:42:04 -0700 (PDT) From: Lee Jones <lee.jones@linaro.org> To: gregkh@linuxfoundation.org, linux-usb@vger.kernel.org Subject: [PATCH 05/30] usb: atm: ueagle-atm: Demote obvious misuse of kerneldoc to standard comment blocks Date: Fri, 3 Jul 2020 18:41:23 +0100 Message-Id: <20200703174148.2749969-6-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200703174148.2749969-1-lee.jones@linaro.org> References: <20200703174148.2749969-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200703_134206_208334_E411B981 X-CRM114-Status: GOOD ( 12.39 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: <linux-arm-kernel.lists.infradead.org> List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=unsubscribe> List-Archive: <http://lists.infradead.org/pipermail/linux-arm-kernel/> List-Post: <mailto:linux-arm-kernel@lists.infradead.org> List-Help: <mailto:linux-arm-kernel-request@lists.infradead.org?subject=help> List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-arm-kernel>, <mailto:linux-arm-kernel-request@lists.infradead.org?subject=subscribe> Cc: Stanislaw Gruszka <stf_xl@wp.pl>, linux-kernel@vger.kernel.org, Damien Bergamini <damien.bergamini@free.fr>, Matthieu CASTET <castet.matthieu@free.fr>, Lee Jones <lee.jones@linaro.org>, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" <linux-arm-kernel-bounces@lists.infradead.org> Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org |
Series |
Fix a bunch more W=1 issues in USB
|
expand
|
diff --git a/drivers/usb/atm/ueagle-atm.c b/drivers/usb/atm/ueagle-atm.c index e9fed9a887377..786299892c7f4 100644 --- a/drivers/usb/atm/ueagle-atm.c +++ b/drivers/usb/atm/ueagle-atm.c @@ -570,7 +570,7 @@ MODULE_PARM_DESC(annex, #define LOAD_INTERNAL 0xA0 #define F8051_USBCS 0x7f92 -/** +/* * uea_send_modem_cmd - Send a command for pre-firmware devices. */ static int uea_send_modem_cmd(struct usb_device *usb, @@ -672,7 +672,7 @@ static void uea_upload_pre_firmware(const struct firmware *fw_entry, uea_leaves(usb); } -/** +/* * uea_load_firmware - Load usb firmware for pre-firmware devices. */ static int uea_load_firmware(struct usb_device *usb, unsigned int ver)
No attempt has been made to document any of the functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/atm/ueagle-atm.c:578: warning: Function parameter or member 'usb' not described in 'uea_send_modem_cmd' drivers/usb/atm/ueagle-atm.c:578: warning: Function parameter or member 'addr' not described in 'uea_send_modem_cmd' drivers/usb/atm/ueagle-atm.c:578: warning: Function parameter or member 'size' not described in 'uea_send_modem_cmd' drivers/usb/atm/ueagle-atm.c:578: warning: Function parameter or member 'buff' not described in 'uea_send_modem_cmd' drivers/usb/atm/ueagle-atm.c:679: warning: Function parameter or member 'usb' not described in 'uea_load_firmware' drivers/usb/atm/ueagle-atm.c:679: warning: Function parameter or member 'ver' not described in 'uea_load_firmware' Cc: Matthieu CASTET <castet.matthieu@free.fr> Cc: Stanislaw Gruszka <stf_xl@wp.pl> Cc: Damien Bergamini <damien.bergamini@free.fr> Signed-off-by: Lee Jones <lee.jones@linaro.org> --- drivers/usb/atm/ueagle-atm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)