From patchwork Mon Jul 6 13:33:10 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 11645835 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id C87BF13B6 for ; Mon, 6 Jul 2020 13:36:09 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4E5A220720 for ; Mon, 6 Jul 2020 13:36:09 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CTaO2rb4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="tb+/K0K1" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4E5A220720 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=1ntlEQ4ZEHkSkhb/f2ZquZT1n7Iibff0vHvHS8R41rE=; b=CTaO2rb4nU5ChB8BGs3+xGXvd givNRfjPPJhwxdsap3CEPkVmADh6OjyOGh6BZadCYNKPhroTUB+4n01gT3lp37e+DicqoQp1ok3dI nSF4mzkcKs0vKyPuegpvEjZ6F9nz3MUP9mFm0csiee0wj5AhpUft7MfvFVqqs4nMOtz07iVZqYzWi o2wbYDR+hW6ZJkHqA8lyGSvaCgPuV1i3DUtyg3Br5d9AabR1dEcE+S0TRLJVG21BgFoAAH3/rA5Jp YRNjWC+pBPdin3u3qJrVg3M95Pv+mFIfDo/l6th0wrmVF8kSt1ozM1U7rbn3/cJtwnRv4NY+pGcyW 39s3HvkdQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFl-000887-5K; Mon, 06 Jul 2020 13:33:49 +0000 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jsRFi-000870-NG for linux-arm-kernel@lists.infradead.org; Mon, 06 Jul 2020 13:33:47 +0000 Received: by mail-wm1-x341.google.com with SMTP id o8so39366439wmh.4 for ; Mon, 06 Jul 2020 06:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=KtWn8hsOXI1tl0MUhSmyvGeFes81dlof0v8VW7+fdbw=; b=tb+/K0K1eA704mpMyghl55v/zWI4mSEucjEWMkto05EJAwtt81Tuc5Ialuiq8LeS2R x7eNhrR5yGpofVpGMlUc+dGvW6hOfzZAKfuPvTYOL9cr6csy+Q7aT4rJAe+QBVgDpCWB JmX38nI6hJKRDaLdaCbKahq0CK0atprPWa2Wn5hZzUEnnjAXQrcx+95LGiam9CAdWbmM QFxzd5VOEiDqMgyMUKWN0JEn5Yco8m9QTRctmmUjIDZ2rJKKvS/HJF17k9YJnzu5eULF XF3nsJOJPonHF1SaySMBGld80Ol8vOnadKhByaY0CkSeG7cHOObHZPhTkBpFLNt2aOaX OXrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=KtWn8hsOXI1tl0MUhSmyvGeFes81dlof0v8VW7+fdbw=; b=GigbTk+5Jj+61MSlPkX4Y8+OpdDUfyg7jZ15Htm8XMB5k6f83ZnQcKk+bbr4KIj+vl rEvzQ7tQjYa165n8IssSHfyR0skiZBdqeX+D1nd9LgBkODB2sKj8qL2djyyWgpongyck atmZ0QBM5r0rshTpn3QbK8LBmeHzdkRABQSv3ZO97f5mm6jkYmK5gkihOWSv+hlQadNG G2/NFUNvxOzHBXvDnwe5MwAhv5gsHQKnYw21BzP9TEpFH3wmzWrlhvCQ8Sel1zk6GbXG Qamaa8yKpgHhbqgBeG22R731UFoJkkLoeXrECxs8cui4NYVhlQLxcNlAA8whI3lphJgk mTaQ== X-Gm-Message-State: AOAM532BqHP43nMJSvSJbdXdyaY5tdsqmsrHHu3LObPmPUR0qoeMuEmb HDNZe1T7Y5j0R54OJ+3KhQopqQ== X-Google-Smtp-Source: ABdhPJxVTByOnTI298yDjNpJQ+8K3fWLg5oZdMazHD2udtCJrLX53D0eLnbVRozcdO4IHjwxa9apZQ== X-Received: by 2002:a7b:cc92:: with SMTP id p18mr51110615wma.4.1594042425621; Mon, 06 Jul 2020 06:33:45 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.206]) by smtp.gmail.com with ESMTPSA id v18sm25416082wrv.49.2020.07.06.06.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Jul 2020 06:33:45 -0700 (PDT) From: Lee Jones To: gregkh@linuxfoundation.org Subject: [PATCH 01/32] usb: misc: legousbtower: Demote obvious misuse of kerneldoc to standard comment blocks Date: Mon, 6 Jul 2020 14:33:10 +0100 Message-Id: <20200706133341.476881-2-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200706133341.476881-1-lee.jones@linaro.org> References: <20200706133341.476881-1-lee.jones@linaro.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200706_093346_801151_85062578 X-CRM114-Status: GOOD ( 12.73 ) X-Spam-Score: -0.2 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.2 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [2a00:1450:4864:20:0:0:0:341 listed in] [list.dnswl.org] -0.0 SPF_PASS SPF: sender matches SPF record 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record -0.1 DKIM_VALID Message has at least one valid DKIM or DK signature -0.1 DKIM_VALID_AU Message has a valid DKIM or DK signature from author's domain -0.1 DKIM_VALID_EF Message has a valid DKIM or DK signature from envelope-from domain 0.1 DKIM_SIGNED Message has a DKIM or DK signature, not necessarily valid X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: david , Juergen Stuber , linux-usb@vger.kernel.org, David Glance , linux-kernel@vger.kernel.org, legousb-devel@lists.sourceforge.net, Lee Jones , linux-arm-kernel@lists.infradead.org Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+patchwork-linux-arm=patchwork.kernel.org@lists.infradead.org No attempt has been made to document any of the demoted functions here. Fixes the following W=1 kernel build warning(s): drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'dev' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'function' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'size' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:280: warning: Function parameter or member 'data' not described in 'lego_usb_tower_debug_data' drivers/usb/misc/legousbtower.c:290: warning: Function parameter or member 'dev' not described in 'tower_delete' drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'inode' not described in 'tower_open' drivers/usb/misc/legousbtower.c:306: warning: Function parameter or member 'file' not described in 'tower_open' drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'inode' not described in 'tower_release' drivers/usb/misc/legousbtower.c:405: warning: Function parameter or member 'file' not described in 'tower_release' drivers/usb/misc/legousbtower.c:452: warning: Function parameter or member 'dev' not described in 'tower_check_for_read_packet' drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'file' not described in 'tower_poll' drivers/usb/misc/legousbtower.c:468: warning: Function parameter or member 'wait' not described in 'tower_poll' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'file' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'off' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:494: warning: Function parameter or member 'whence' not described in 'tower_llseek' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'file' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'buffer' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'count' not described in 'tower_read' drivers/usb/misc/legousbtower.c:503: warning: Function parameter or member 'ppos' not described in 'tower_read' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'file' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'buffer' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'count' not described in 'tower_write' drivers/usb/misc/legousbtower.c:587: warning: Function parameter or member 'ppos' not described in 'tower_write' drivers/usb/misc/legousbtower.c:669: warning: Function parameter or member 'urb' not described in 'tower_interrupt_in_callback' drivers/usb/misc/legousbtower.c:724: warning: Function parameter or member 'urb' not described in 'tower_interrupt_out_callback' drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'interface' not described in 'tower_probe' drivers/usb/misc/legousbtower.c:752: warning: Function parameter or member 'id' not described in 'tower_probe' drivers/usb/misc/legousbtower.c:863: warning: Function parameter or member 'interface' not described in 'tower_disconnect' Cc: Juergen Stuber Cc: David Glance Cc: david Cc: legousb-devel@lists.sourceforge.net Signed-off-by: Lee Jones --- drivers/usb/misc/legousbtower.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/drivers/usb/misc/legousbtower.c b/drivers/usb/misc/legousbtower.c index ab4b98b041158..8aca55c4c95f1 100644 --- a/drivers/usb/misc/legousbtower.c +++ b/drivers/usb/misc/legousbtower.c @@ -283,7 +283,7 @@ static inline void lego_usb_tower_debug_data(struct device *dev, } -/** +/* * tower_delete */ static inline void tower_delete(struct lego_usb_tower *dev) @@ -299,7 +299,7 @@ static inline void tower_delete(struct lego_usb_tower *dev) } -/** +/* * tower_open */ static int tower_open(struct inode *inode, struct file *file) @@ -398,7 +398,7 @@ static int tower_open(struct inode *inode, struct file *file) return retval; } -/** +/* * tower_release */ static int tower_release(struct inode *inode, struct file *file) @@ -440,7 +440,7 @@ static int tower_release(struct inode *inode, struct file *file) return retval; } -/** +/* * tower_check_for_read_packet * * To get correct semantics for signals and non-blocking I/O @@ -461,7 +461,7 @@ static void tower_check_for_read_packet(struct lego_usb_tower *dev) } -/** +/* * tower_poll */ static __poll_t tower_poll(struct file *file, poll_table *wait) @@ -487,7 +487,7 @@ static __poll_t tower_poll(struct file *file, poll_table *wait) } -/** +/* * tower_llseek */ static loff_t tower_llseek(struct file *file, loff_t off, int whence) @@ -496,7 +496,7 @@ static loff_t tower_llseek(struct file *file, loff_t off, int whence) } -/** +/* * tower_read */ static ssize_t tower_read(struct file *file, char __user *buffer, size_t count, loff_t *ppos) @@ -580,7 +580,7 @@ static ssize_t tower_read(struct file *file, char __user *buffer, size_t count, } -/** +/* * tower_write */ static ssize_t tower_write(struct file *file, const char __user *buffer, size_t count, loff_t *ppos) @@ -662,7 +662,7 @@ static ssize_t tower_write(struct file *file, const char __user *buffer, size_t } -/** +/* * tower_interrupt_in_callback */ static void tower_interrupt_in_callback(struct urb *urb) @@ -717,7 +717,7 @@ static void tower_interrupt_in_callback(struct urb *urb) } -/** +/* * tower_interrupt_out_callback */ static void tower_interrupt_out_callback(struct urb *urb) @@ -742,7 +742,7 @@ static void tower_interrupt_out_callback(struct urb *urb) } -/** +/* * tower_probe * * Called by the usb core when a new device is connected that it thinks @@ -854,7 +854,7 @@ static int tower_probe(struct usb_interface *interface, const struct usb_device_ } -/** +/* * tower_disconnect * * Called by the usb core when the device is removed from the system.