| Message ID | 20200706150013.35326-1-vincenzo.frascino@arm.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU | expand |
On 06.07.2020 18:00, Vincenzo Frascino wrote: > imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only > when CONFIG_PM_SLEEP configuration options is enabled. Having it > disabled triggers the following warning at compile time: > > drivers/mailbox/imx-mailbox.c:611:12: warning: ‘imx_mu_resume_noirq’ > defined but not used [-Wunused-function] > static int imx_mu_resume_noirq(struct device *dev) > > drivers/mailbox/imx-mailbox.c:601:12: warning: ‘imx_mu_suspend_noirq’ > defined but not used [-Wunused-function] > static int imx_mu_suspend_noirq(struct device *dev) > > Make imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to > address the issue. > > Cc: Jassi Brar <jassisinghbrar@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com>
> From: Vincenzo Frascino <vincenzo.frascino@arm.com> > Sent: Monday, July 6, 2020 11:00 PM > > imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only > when CONFIG_PM_SLEEP configuration options is enabled. Having it disabled > triggers the following warning at compile time: > > drivers/mailbox/imx-mailbox.c:611:12: warning: ‘imx_mu_resume_noirq’ > defined but not used [-Wunused-function] > static int imx_mu_resume_noirq(struct device *dev) > > drivers/mailbox/imx-mailbox.c:601:12: warning: ‘imx_mu_suspend_noirq’ > defined but not used [-Wunused-function] > static int imx_mu_suspend_noirq(struct device *dev) > > Make imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to > address the issue. > > Cc: Jassi Brar <jassisinghbrar@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> There's already a fix: https://lkml.org/lkml/2020/6/22/1555 Regards Aisheng > --- > drivers/mailbox/imx-mailbox.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c > index 7205b825c8b5..f54f36948414 100644 > --- a/drivers/mailbox/imx-mailbox.c > +++ b/drivers/mailbox/imx-mailbox.c > @@ -598,7 +598,7 @@ static const struct of_device_id imx_mu_dt_ids[] = { }; > MODULE_DEVICE_TABLE(of, imx_mu_dt_ids); > > -static int imx_mu_suspend_noirq(struct device *dev) > +static int __maybe_unused imx_mu_suspend_noirq(struct device *dev) > { > struct imx_mu_priv *priv = dev_get_drvdata(dev); > > @@ -608,7 +608,7 @@ static int imx_mu_suspend_noirq(struct device *dev) > return 0; > } > > -static int imx_mu_resume_noirq(struct device *dev) > +static int __maybe_unused imx_mu_resume_noirq(struct device *dev) > { > struct imx_mu_priv *priv = dev_get_drvdata(dev); > > -- > 2.27.0
diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c index 7205b825c8b5..f54f36948414 100644 --- a/drivers/mailbox/imx-mailbox.c +++ b/drivers/mailbox/imx-mailbox.c @@ -598,7 +598,7 @@ static const struct of_device_id imx_mu_dt_ids[] = { }; MODULE_DEVICE_TABLE(of, imx_mu_dt_ids); -static int imx_mu_suspend_noirq(struct device *dev) +static int __maybe_unused imx_mu_suspend_noirq(struct device *dev) { struct imx_mu_priv *priv = dev_get_drvdata(dev); @@ -608,7 +608,7 @@ static int imx_mu_suspend_noirq(struct device *dev) return 0; } -static int imx_mu_resume_noirq(struct device *dev) +static int __maybe_unused imx_mu_resume_noirq(struct device *dev) { struct imx_mu_priv *priv = dev_get_drvdata(dev);
imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only when CONFIG_PM_SLEEP configuration options is enabled. Having it disabled triggers the following warning at compile time: drivers/mailbox/imx-mailbox.c:611:12: warning: ‘imx_mu_resume_noirq’ defined but not used [-Wunused-function] static int imx_mu_resume_noirq(struct device *dev) drivers/mailbox/imx-mailbox.c:601:12: warning: ‘imx_mu_suspend_noirq’ defined but not used [-Wunused-function] static int imx_mu_suspend_noirq(struct device *dev) Make imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to address the issue. Cc: Jassi Brar <jassisinghbrar@gmail.com> Cc: Shawn Guo <shawnguo@kernel.org> Cc: Sascha Hauer <s.hauer@pengutronix.de> Cc: Pengutronix Kernel Team <kernel@pengutronix.de> Cc: Fabio Estevam <festevam@gmail.com> Cc: NXP Linux Team <linux-imx@nxp.com> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> --- drivers/mailbox/imx-mailbox.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)